Skip to content
Snippets Groups Projects

va: Do not use a common parent_class in vabasedec.

Merged He Junyan requested to merge He_Junyan/gst-plugins-bad:va_dec_no_common_parent into master
All threads resolved!

We have only one copy of gst_va_base_dec_parent_class inside the vabasedec, so it can not handle the case when there are multi va decoders inside one pipeline. The pipeline:

gst-launch-1.0 filesrc location=xxx.h264 ! h264parse
! vah264dec ! msdkh265enc ! vah265dec ! fakesink

generates a assertion of

"invalid cast from 'GstVaH264Dec' to 'GstH265Decoder"

and gets a crash.

We should keep the parent_class for each decoder type.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • He Junyan added 1 commit

    added 1 commit

    • a249d2f6 - va: Do not use a common parent_class in vabasedec.

    Compare with previous version

  • He Junyan resolved all threads

    resolved all threads

  • added 1 commit

    • 64b59610 - va: Do not use a common parent_class in vabasedec.

    Compare with previous version

  • changed milestone to %1.19.1

  • Please register or sign in to reply
    Loading