Skip to content

webrtcbin: Split pad name from mline

The simple case where this breaks is if you add a datachannel and want to add a new pad (a new media) after). Another case where this is broken is if the order of the media is forced to something different by the peer.

It's more simple to just split both things completely. In practice, the pads will be named in the order in which they are allocated, so it shouldn't change the current behaviour, just enable new ones.

The other patch is a workaround to a race between releasing a pad and the main thread not being stopped... I'm guessing that the safety of the pad release/transceiver release needs to be re-though, I guess that also means implementing the traceiver "stopped" mode.

This should address more completely the bug that !1992 (closed) was trying to fix.

Merge request reports