Skip to content

h2645parser: Catch overflows in AVC/HEVC NAL unit length calculations

Sebastian Dröge requested to merge slomo/gst-plugins-bad:h26xparse-avc-length-overflow into master

Offset and size are stored as 32 bit guint and might overflow when adding the nal_length_size, so let's avoid that.

For the size this would happen if the AVC/HEVC NAL unit size happens to be stored in 4 bytes and is 4294967292 or higher, which is likely corrupted data anyway.

For the offset this is something for the caller of these functions to take care of but is unlikely to happen as it would require parsing on a >4GB buffer.

Allowing these overflows causes all kinds of follow-up bugs in the h2645parse elements, ranging from infinite loops and memory leaks to potential memory corruptions.

Edited by Sebastian Dröge

Merge request reports