Fix the wrong mapping between chroma-format and subsampling_x/y in av1 and vp9 parse.
Merge request reports
Activity
- Resolved by He Junyan
@seungha.yang, I am still a little confused why the color space need to check here? Other parse such as h265 parse seems that it always sends the chroma-format info.
580 if (self->color_space != GST_VP9_CS_SRGB) { 581 if (self->parser->subsampling_x == 1 && self->parser->subsampling_y == 1) 582 chroma_format = "4:2:0"; 583 else if (self->parser->subsampling_x == 1 && 584 self->parser->subsampling_y == 0) 585 chroma_format = "4:2:2"; 586 else if (self->parser->subsampling_x == 0 && 587 self->parser->subsampling_y == 1) 588 chroma_format = "4:4:0"; 589 else if (self->parser->subsampling_x == 0 && 590 self->parser->subsampling_y == 0) 591 chroma_format = "4:4:4"; 592 593 if (chroma_format) 594 gst_caps_set_simple (final_caps, 595 "chroma-format", G_TYPE_STRING, chroma_format, NULL); 596 }
- Resolved by He Junyan
Please add
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1502
to the commit message of the relevant commit.
assigned to @gstreamer-merge-bot
mentioned in commit He_Junyan/gst-plugins-bad@1029c84d
mentioned in commit He_Junyan/gst-plugins-bad@7196abf7
mentioned in commit He_Junyan/gst-plugins-bad@e8ec8f7d
added 6 commits
-
4a5b6dbe...82a9e463 - 3 commits from branch
gstreamer:master
- 1029c84d - vp9parse: Fix the subsampling_x/y to chroma format mapping.
- 7196abf7 - av1parse: Fix some issues in the src caps.
- e8ec8f7d - codecparsers: av1: Fix a typo in frame_restoration_type setting.
Toggle commit list-
4a5b6dbe...82a9e463 - 3 commits from branch
changed milestone to %1.19.1