Skip to content

WIP: webrtc: add ice-lite support

eater requested to merge eater/gst-plugins-bad:feature/webrtc/ice-lite into master

Before I start intensively testing and fixing all the bugs and stuff I kind of want some feedback on how I implemented this

libnice only allows us to set full-mode at construction via either full-mode or via the NICE_AGENT_OPTION_LITE_MODE flag.

Since GstElement's seem to be made through GstElementFactory's and won't allow to set properties for construction the only "reasonable" solution was to defer the creation of the NiceAgent till it's actually needed, this however means Invoking Unexpected Behaviour if an user action unsuspectingly spawned the NiceAgent

I would like to hear some thoughts if there's a better way or if this is Okay

Merge request reports