Skip to content

webrtcbin: Merge the RTX SSRCs from all transceivers when bundling

If you enable RTX (set "do-nack"=TRUE on the transceiver) and use bundle, and do that in the right order. Then it the rtpbin pad will be requested before the mline has been set for the transceivers, causing it to returns trans=NULL and crashing when it tries to dereference trans.

In any case, I think the logic was wrong, as there can be multiple transceivers referencing the same TransportStream and I think we actually need to aggregate all of them to make it work.

Here is a standalone test program to reproduce the crash: test-webrtc.c. The elements/webrtc.c unit tests framework requests and connects all the pads before doing the SDP dance, so I would have to ignore all of it to add a unit test in there.

Merge request reports