Skip to content
Snippets Groups Projects

codecs: h264decoder: Add support for interlaced stream

Merged Seungha Yang requested to merge seungha.yang/gst-plugins-bad:h264-interlaced into master

Initial implementation to support decoding interlaced h264 stream

Edited by Seungha Yang

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Dufresne
    • Resolved by Seungha Yang

      I'm not yet convince of the Frame wrapping pictures approach (I think the reflex gstreamer-vaapi style). I personally prefer the JM approach, a picture remains 1:1 with the output buffers, and then it contains a bit fields of what has been decoders (top, bottom, or both of MBAFF slices) along with poc being an array of 2 entries. Do you have more details around this design decision ?

  • Seungha Yang mentioned in merge request !1776 (closed)

    mentioned in merge request !1776 (closed)

  • Seungha Yang added 336 commits

    added 336 commits

    • dfba5e8c...81151145 - 331 commits from branch gstreamer:master
    • de8f5534 - codecs: h264decoder: Store reference picture type using enum value
    • 7e1b2d32 - codecs: h264decoder: Remove interlaced stream related constraints
    • 6692a66c - codecs: h264decoder: Rename DPB methods
    • a4bbf49e - WIP: codecs: h264decoder: Add support for interlaced stream
    • 0f880e41 - WIP: d3d11h264dec: Add support for interlaced stream

    Compare with previous version

  • Seungha Yang resolved all threads

    resolved all threads

  • Seungha Yang added 9 commits

    added 9 commits

    • 0f880e41...5342b053 - 4 commits from branch gstreamer:master
    • 45e34a00 - codecs: h264decoder: Store reference picture type using enum value
    • f0559a01 - codecs: h264decoder: Remove interlaced stream related constraints
    • 85cab5f5 - codecs: h264decoder: Rename DPB methods
    • ec06b558 - codecs: h264decoder: Add support for interlaced stream
    • 80b27055 - d3d11h264dec: Add support for interlaced stream

    Compare with previous version

  • Seungha Yang unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Updating current status

    • d3d11h264dec can pass 127/135 using fluster
      • CVFC1_Sony_C -> cropping window, maybe ignored or can be revisit later
      • FM1_BT_B, FM1_FT_E, FM2_SVA_C-> slice group (FMO)
      • MR6_BT_B, MR8_BT_B -> PAFF, should be fixed at some point
      • SP1_BT_A, sp2_bt_b -> extension profiles
    Edited by Seungha Yang
  • Seungha Yang added 7 commits

    added 7 commits

    • 80b27055...a2a73c02 - 2 commits from branch gstreamer:master
    • 2a61bec9 - codecs: h264decoder: Store reference picture type using enum value
    • fbf0ccc5 - codecs: h264decoder: Remove interlaced stream related constraints
    • 5e5eaf03 - codecs: h264decoder: Rename DPB methods
    • 7f190ecc - codecs: h264decoder: Add support for interlaced stream
    • 1d276779 - d3d11h264dec: Add support for interlaced stream

    Compare with previous version

  • Seungha Yang added 2 commits

    added 2 commits

    • 83c9b1ed - codecs: h264decoder: Add support for interlaced stream
    • 0d7fade4 - d3d11h264dec: Add support for interlaced stream

    Compare with previous version

  • Seungha Yang added 4 commits

    added 4 commits

    • 40cf9a61 - codecs: h264decoder: Remove interlaced stream related constraints
    • dd226d1a - codecs: h264decoder: Rename DPB methods
    • 30f07e40 - codecs: h264decoder: Add support for interlaced stream
    • 3346291f - d3d11h264dec: Add support for interlaced stream

    Compare with previous version

  • Seungha Yang resolved all threads

    resolved all threads

  • I'm running CI now, since last time I build with doc, there was few warnings, perhaps we could fix these trivial at the same time.

  • Seungha Yang added 4 commits

    added 4 commits

    • 30224700 - codecs: h264decoder: Remove interlaced stream related constraints
    • 428562a0 - codecs: h264decoder: Rename DPB methods
    • 1a8fabc8 - codecs: h264decoder: Add support for interlaced stream
    • 866931cb - d3d11h264dec: Add support for interlaced stream

    Compare with previous version

  • arg...

    ERROR: [check-missing-since-markers]: (missing-since-marker): /builds/seungha.yang/gst-plugins-bad/gst-build/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gsth264decoder.h: Missing since marker for GstH264DecoderClass::new_field_picture
    Downloading https://github.com/hotdoc/hotdoc_lumen_theme/releases/download/0.9999999/hotdoc_lumen_theme-0.9999999.tar.xz?sha256=ef3b9dd59550c2ba31a7fbcae1f69e6e77147f5e6e224f37a6cb55c162957437
  • If this try is also failed, maybe I need to request some help @meh :sweat_smile:

  • Seungha Yang added 4 commits

    added 4 commits

    • 9680c43f - codecs: h264decoder: Remove interlaced stream related constraints
    • 87ae8885 - codecs: h264decoder: Rename DPB methods
    • 68387afb - codecs: h264decoder: Add support for interlaced stream
    • 7cf962c3 - d3d11h264dec: Add support for interlaced stream

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading