Skip to content

webrtc, rtmp2: Fix parsing of userinfo in URI strings, warn if userinfo is not escaped

Nirbheek Chauhan requested to merge nirbheek/gst-plugins-bad:fix-userinfo-parsing into master

While parsing the string, gst_uri_from_string() also unescapes the userinfo. This is bad if your username contains a : character, since we will then split the userinfo at the wrong location when parsing it.

To fix this, we can use the new gst_uri_from_string_escaped() API that was added in gstreamer!583 (merged)

Fixes #831 (closed)

Also warn ff the user/pass aren't escaped, since the userinfo will be ambiguous and we won't know where to split. We will accidentally get it right if the : belongs in the password

Merge request reports