Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-bad
gst-plugins-bad
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,016
    • Issues 1,016
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 200
    • Merge Requests 200
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-badgst-plugins-bad
  • Merge Requests
  • !1465

Merged
Opened Jul 25, 2020 by Tim-Philipp Müller@tpm🐠Owner2 of 3 tasks completed2/3 tasks

sctp: bundle usrsctp

  • Overview 34
  • Commits 3
  • Pipelines 35
  • Changes 73
sctp: import internal copy of usrsctp library
There are problems with global shared state and no API stability
guarantees, and we can't rely on distros shipping the fixes we
need. Both firefox and Chrome bundle their own copies too.

Imported from https://github.com/sctplab/usrsctp,
commit 547d3b46c64876c0336b9eef297fda58dbe1adaf
Date: Thu Jul 23 21:49:32 2020 +0200

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/870

sctp: hook up internal copy of libusrsctp to build
Add option 'sctp-internal-usrsctp' so people can choose
to build againts the distro version instead.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/870

Compiler warnings need reviewing (and/or suppressing) to make sure things are hooked up right.

I also haven't tested this yet besides the basic build.

Todo

  • test
  • figure out how to exempt those files or dirs from gst-indent in local pre-commit hook, don't want to add indent on/off markers to all these files (removed for now, can just use git commit -n for time being)
  • make gst indent job on CI honour the .indentignore file: gst-ci!328 (merged)
Edited Aug 14, 2020 by Tim-Philipp Müller
Assignee
Assign to
Reviewer
Request review from
1.17.90
Milestone
1.17.90
Assign milestone
Time tracking
Reference: gstreamer/gst-plugins-bad!1465
Source branch: bundle-usrsctp