mpegtsdemux: Deliver all packets to tsparse (!1300) · Merge requests · GStreamer / gst-plugins-bad · GitLab

Snippets Groups Projects

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

The migration is almost done, at least the rest should happen in the background. There are still a few technical difference between the old cluster and the new ones, and they are summarized in this issue. Please pay attention to the TL:DR at the end of the comment.

Merged Jan Alexander Steffens requested to merge heftig/gst-plugins-bad:tsparse-passthrough into master 4 years ago

34af8ed6 changed the code to use the packetizer's packets instead of the incoming buffers, but mpegtsbase didn't actually push all packets to the subclass. As a result, padding (PID 0x1FFF) packets got lost.

Add a new boolean to toggle pushing unknown packets to mpegtsbase and have mpegtsparse make use of it.

Activity

Jan Alexander Steffens added 1 commit 4 years ago
added 1 commit

c1552255 - mpegtsdemux: tests: Test that tsparse doesn't drop padding

Compare with previous version
Jan Schmidt @thaytan · 4 years ago

Maintainer

LGTM
Jan Alexander Steffens assigned to @gstreamer-merge-bot and unassigned @heftig 4 years ago

assigned to @gstreamer-merge-bot and unassigned @heftig
Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@a41dda3e 4 years ago

mentioned in commit heftig/gst-plugins-bad@a41dda3e
Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@9926a645 4 years ago

mentioned in commit heftig/gst-plugins-bad@9926a645
GStreamer Marge Bot added 4 commits 4 years ago
added 4 commits

c1552255...06f3a0ed - 2 commits from branch gstreamer:master

9926a645 - mpegtsdemux: Deliver all packets to tsparse

a41dda3e - mpegtsdemux: tests: Test that tsparse doesn't drop padding

Compare with previous version
GStreamer Marge Bot assigned to @heftig and unassigned @gstreamer-merge-bot 4 years ago

assigned to @heftig and unassigned @gstreamer-merge-bot
GStreamer Marge Bot @gstreamer-merge-bot · 4 years ago

Developer

I couldn't merge this branch: CI failed!
Jan Schmidt @thaytan · 4 years ago

Maintainer

Merge won't work right now - need to fix the CI
Jan Schmidt assigned to @gstreamer-merge-bot and unassigned @heftig 4 years ago

assigned to @gstreamer-merge-bot and unassigned @heftig
Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@aad9cf80 4 years ago

mentioned in commit heftig/gst-plugins-bad@aad9cf80
Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@23a2916a 4 years ago

mentioned in commit heftig/gst-plugins-bad@23a2916a
GStreamer Marge Bot added 6 commits 4 years ago
added 6 commits

a41dda3e...2dc689c2 - 4 commits from branch gstreamer:master

23a2916a - mpegtsdemux: Deliver all packets to tsparse

aad9cf80 - mpegtsdemux: tests: Test that tsparse doesn't drop padding

Compare with previous version
GStreamer Marge Bot merged 4 years ago

merged
GStreamer Release Monkey changed milestone to %1.17.1 4 years ago

changed milestone to %1.17.1

Please register or sign in to reply