Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-bad gst-plugins-bad
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 982
    • Issues 982
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 125
    • Merge requests 125
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-badgst-plugins-bad
  • Merge requests
  • !1163

meson: Don't use get_option('buildtype')

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nirbheek Chauhan requested to merge nirbheek/gst-plugins-bad:fix-build-type-usage into master Apr 03, 2020
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 3

We should directly check the values of the debug and optimization options instead.

get_option('buildtype') will return 'custom' for most combinations of -Doptimization and -Ddebug, but those two will always be set correctly if only -Dbuildtype is set. So we should look at those options directly.

For the two-way mapping between buildtype and optimization

  • debug, see this table: https://mesonbuild.com/Builtin-options.html#build-type-options
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-build-type-usage