Skip to content
Snippets Groups Projects

Improve hevc parser getting profile

Merged He Junyan requested to merge He_Junyan/gst-plugins-bad:hevc_parser_profile into master
All threads resolved!

Fix getting profile bugs in h265parser. The h265parser now recognizes SCC stream as high-throughput profiles.

Edited by He Junyan

Merge request reports

Merge request pipeline #138945 passed

Merge request pipeline passed for 9082f103

Approval is optional

Merged by GStreamer Marge BotGStreamer Marge Bot 4 years ago (Apr 28, 2020 2:28pm UTC)

Merge details

  • Changes merged into master with 9082f103.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Dufresne
  • He Junyan changed the description

    changed the description

  • Seungha Yang
  • He Junyan added 3 commits

    added 3 commits

    • 09d41b0b - 1 commit from branch gstreamer:master
    • 87848daa - libs: h265parser: Fix a bug for getting extension profile.
    • cc966ed1 - libs: h265parser: rename the FormatRangeExtensionProfile

    Compare with previous version

  • He Junyan resolved all threads

    resolved all threads

  • He Junyan added 23 commits

    added 23 commits

    • cc966ed1...c3a9d2dc - 21 commits from branch gstreamer:master
    • d67606ef - libs: h265parser: Fix a bug for getting extension profile.
    • 8ab0f1c6 - libs: h265parser: rename the FormatRangeExtensionProfile

    Compare with previous version

  • Nicolas Dufresne added 5 commits

    added 5 commits

    • 8ab0f1c6...7f5347a6 - 3 commits from branch gstreamer:master
    • 6c421544 - libs: h265parser: Fix a bug for getting extension profile.
    • 0c5ecca8 - libs: h265parser: rename the FormatRangeExtensionProfile

    Compare with previous version

  • He Junyan added 5 commits

    added 5 commits

    • 0c5ecca8...3208e3d3 - 3 commits from branch gstreamer:master
    • 51bb5deb - libs: h265parser: Fix a bug for getting extension profile.
    • 68fa396b - libs: h265parser: rename the FormatRangeExtensionProfile

    Compare with previous version

  • mentioned in merge request gstreamer-vaapi!311 (merged)

  • He Junyan added 3 commits

    added 3 commits

    • 0775f937 - libs: h265parser: Fix a bug for getting extension profile.
    • bb0e445c - libs: h265parser: rename the FormatRangeExtensionProfile
    • a0338876 - libs: h265parser: improve the sort_fre for profiles.

    Compare with previous version

  • He Junyan added 107 commits

    added 107 commits

    • a0338876...691fdb85 - 104 commits from branch gstreamer:master
    • 92fb61a2 - libs: h265parser: Fix a bug for getting extension profile.
    • ddba2bd0 - libs: h265parser: rename the FormatRangeExtensionProfile
    • 643a63a6 - libs: h265parser: improve the sort_fre for profiles.

    Compare with previous version

  • He Junyan added 1 commit

    added 1 commit

    • 8db88fb2 - libs: h265parser: improve the sort_fre for profiles.

    Compare with previous version

  • He Junyan added 1 commit

    added 1 commit

    • c083a76f - libs: h265parser: improve the sort_fre for profiles.

    Compare with previous version

  • He Junyan added 1 commit

    added 1 commit

    • e83ab0a0 - libs: h265parser: improve the sort_fre for profiles.

    Compare with previous version

  • He Junyan added 6 commits

    added 6 commits

    • 2e9f9051 - libs: h265parser: Fix a bug for getting extension profile.
    • bcc3f790 - libs: h265parser: rename the FormatRangeExtensionProfile
    • 4e133cbd - libs: h265parser: select extension profile by profile idc.
    • 377190ba - test: h265parser: Add more check or h265 extensions.
    • bfcff16e - libs: h265parser: Add High throughput scc extensions profiles' IDC.
    • 1b44ccd8 - test: h265parser: Add check for high throughput scc.

    Compare with previous version

  • Author Developer

    Thinking back and forth, I think separate the function into different IDCs is more suitable. Because different extensions support different features and should not be compatible.

    Add all tests for this modificaition.

  • Author Developer

    @ndufresne and @seungha.yang, do you have more idea about this? And @haihao, we also need this to make MSDK work with SCC.

  • I am not against this change.

  • Is there any other comment? I'll merge this patch if no objection.

  • Will need another pass of review, I see typos in commit messages notably. Because I forgot, what's the state of the copy in pbutils? Did it need to be sync, I remember asking, but can't find / understand the answer.

    cc @gdesmott Does it still work for your use case in gst-omx ?

  • cc @gdesmott Does it still work for your use case in gst-omx ?

    As long as we don't change string names of profiles, I think so, yes.

  • He Junyan added 62 commits

    added 62 commits

    • 1b44ccd8...851557af - 56 commits from branch gstreamer:master
    • d655c07f - libs: h265parser: Fix a bug for getting extension profile.
    • 4b46ee30 - libs: h265parser: rename the FormatRangeExtensionProfile
    • bacf12de - libs: h265parser: select extension profile by profile idc.
    • 6863a1ba - test: h265parser: Add more check or h265 extensions.
    • cbfcabcd - libs: h265parser: Add High throughput scc extensions profiles' IDC.
    • 99dc1612 - test: h265parser: Add check for high throughput scc.

    Compare with previous version

  • mentioned in merge request gst-plugins-base!645 (merged)

  • He Junyan added 9 commits

    added 9 commits

    • 99dc1612...ed6236f5 - 3 commits from branch gstreamer:master
    • ddf5a5f6 - libs: h265parser: Fix a bug for getting extension profile.
    • 12effd24 - libs: h265parser: rename the FormatRangeExtensionProfile
    • a31cb336 - libs: h265parser: select extension profile by profile idc.
    • 9812be32 - test: h265parser: Add more check or h265 extensions.
    • acb9b978 - libs: h265parser: Add High throughput scc extensions profiles' IDC.
    • c2e083a0 - test: h265parser: Add check for high throughput scc.

    Compare with previous version

  • He Junyan resolved all threads

    resolved all threads

  • added 8 commits

    • c2e083a0...1d38728d - 2 commits from branch gstreamer:master
    • e99b962c - libs: h265parser: Fix a bug for getting extension profile.
    • f4ddccb0 - libs: h265parser: rename the FormatRangeExtensionProfile
    • 35bf824b - libs: h265parser: select extension profile by profile idc.
    • be1cdca7 - test: h265parser: Add more check or h265 extensions.
    • bd2fb6cb - libs: h265parser: Add High throughput scc extensions profiles' IDC.
    • 9082f103 - test: h265parser: Add check for high throughput scc.

    Compare with previous version

  • changed milestone to %1.17.1

  • Please register or sign in to reply
    Loading