Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-bad
gst-plugins-bad
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,001
    • Issues 1,001
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 194
    • Merge Requests 194
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GStreamer
  • gst-plugins-badgst-plugins-bad
  • Issues
  • #640

Closed
Open
Opened Dec 10, 2017 by Bugzilla Migration User@bugzilla-migration

kmssink: Crop Meta support only works if the proposed pool has been used

Submitted by Nicolas Dufresne @ndufresne

Link to original bug (#791450)

Description

++ This is the same as https://bugzilla.gnome.org/show_bug.cgi?id=791449

Whenever the proposed pool is not used upstream, the element fails. The reason is that buffer containing crop meta are larger then caps width/height used to create the internal pool.

We need to delay the creation of the pool, and then alter the caps width/height with the width/height found in the incoming buffer video meta. As a side effect, we also need to validate this width/height every-time.

I'll post the videocrop patches needed to test this easily soon, meanwhile the test pipeline will be:

videotestsrc ! videocrop top=100 ! tee ! kmsimagesink

Tee does not drop the allocation query, but will not use downstream pools.

The result is a black or green image (depends on the color format) and:

CRITICAL **: gst_video_frame_copy: assertion 'dinfo->width == sinfo->width && dinfo->height == sinfo->height' failed

Blocking

  • Bug 746087
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gstreamer/gst-plugins-bad#640