Revert "gstreamer-full: Fix link with x264"

This reverts commit e236d4f7.

Revert the use -BSymbolic which is introducing bad initialization for global variable such as _gst_caps_features_any in gst/gstcapsfeatures.c+71

#108 (closed)

So what or where would the correct fix be, then?

Here is a beginning of anwser:

#108 (comment 649066)

I would recommend to disable x264 support when building gstreamer-full but I dont know if there is another approach possible?

added 12 commits

• 64165eec...05f70661 - 9 commits from branch gstreamer:master
• 6947e1e3 - Revert "gstreamer-full: Fix link with x264"
• 4d7972a2 - gst-full: use a default version script
• 205af2b8 - gstreamer-full: add assert for global symbols

Compare with previous version

added 2 commits

• e5e33045 - gst-full: use a default version script
• 19b4bf72 - gstreamer-full: add assert for global symbols

Compare with previous version

mentioned in issue #108 (closed)

@nirbheek see my comment in #108 (closed)

I don't think we should need a version script, we already flag public APIs with GST_API. However gst-full probably needs gnu_symbol_visibility: 'hidden'.

Regarding GStreamer, you are right, we already have GST_API mechanism but a lib like x264 does not have this kind of mechanism to keep local var like x264_cabac_range_lps.

All the code inside gstreamer-full library should be kept local except the public code of glib/gstreamer used by the 3rd party application.

added 3 commits

• e0223b51 - gst-full: use a default version script
• 24d588e4 - Revert "gstreamer-full: Fix link with x264"
• 3a69febf - gstreamer-full: add assert for global symbols

Compare with previous version

added 4 commits

• 441c2de3 - gst-full: use a default version script
• 078e7ccb - Revert "gstreamer-full: Fix link with x264"
• 6441b204 - gstreamer-full: add assert for global symbols
• fe0fa2f4 - gst-full: use '-Wl,-Bsymbolic-functions' to reduce footprint

Compare with previous version

added 4 commits

• 052d396c - gst-full: use a default version script
• 5cece5e5 - Revert "gstreamer-full: Fix link with x264"
• 35b71a68 - gstreamer-full: add assert for global symbols
• fc4876e6 - gst-full: use '-Wl,-Bsymbolic-functions' to reduce footprint

Compare with previous version

mentioned in issue gstreamer/meson-ports/ffmpeg#21 (closed)

resolved all threads

approved this merge request

assigned to @gstreamer-merge-bot

assigned to @dabrain34 and unassigned @gstreamer-merge-bot

I couldn't merge this branch: Failed to push rebased changes, check my logs!