Skip to content
Snippets Groups Projects

Revert "gstreamer-full: Fix link with x264"

All threads resolved!

This reverts commit e236d4f7.

Revert the use -BSymbolic which is introducing bad initialization for global variable such as _gst_caps_features_any in gst/gstcapsfeatures.c+71

#108 (closed)

Merge request reports

Merge request pipeline #213717 passed

Merge request pipeline passed for f8252751

Approved by

Merged by GStreamer Marge BotGStreamer Marge Bot 4 years ago (Oct 14, 2020 3:28pm UTC)

Merge details

  • Changes merged into master with f8252751.
  • Deleted the source branch.

Pipeline #213748 waiting for manual action

Pipeline waiting for manual action for f8252751 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Guillaume Desmottes
  • Guillaume Desmottes
  • added 3 commits

    • e0223b51 - gst-full: use a default version script
    • 24d588e4 - Revert "gstreamer-full: Fix link with x264"
    • 3a69febf - gstreamer-full: add assert for global symbols

    Compare with previous version

  • added 4 commits

    • 441c2de3 - gst-full: use a default version script
    • 078e7ccb - Revert "gstreamer-full: Fix link with x264"
    • 6441b204 - gstreamer-full: add assert for global symbols
    • fe0fa2f4 - gst-full: use '-Wl,-Bsymbolic-functions' to reduce footprint

    Compare with previous version

  • added 4 commits

    • 052d396c - gst-full: use a default version script
    • 5cece5e5 - Revert "gstreamer-full: Fix link with x264"
    • 35b71a68 - gstreamer-full: add assert for global symbols
    • fc4876e6 - gst-full: use '-Wl,-Bsymbolic-functions' to reduce footprint

    Compare with previous version

  • Stéphane Cerveau resolved all threads

    resolved all threads

  • Guillaume Desmottes approved this merge request

    approved this merge request

  • assigned to @dabrain34 and unassigned @gstreamer-merge-bot

  • I couldn't merge this branch: Failed to push rebased changes, check my logs!

  • added 5 commits

    • 71616b93 - 1 commit from branch gstreamer:master
    • 31a1beaf - gst-full: use a default version script
    • bd05b176 - Revert "gstreamer-full: Fix link with x264"
    • 4611bb5b - gstreamer-full: add assert for global symbols
    • f9939628 - gst-full: use '-Wl,-Bsymbolic-functions' to reduce footprint

    Compare with previous version

  • assigned to @gstreamer-merge-bot and unassigned @dabrain34

  • assigned to @dabrain34 and unassigned @gstreamer-merge-bot

  • I couldn't merge this branch: Failed to push rebased changes, check my logs!

  • assigned to @gstreamer-merge-bot and unassigned @dabrain34

  • added 4 commits

    • d5dcbdb5 - gst-full: use a default version script
    • 751aacd8 - Revert "gstreamer-full: Fix link with x264"
    • 139fbac9 - gstreamer-full: add assert for global symbols
    • f8252751 - gst-full: use '-Wl,-Bsymbolic-functions' to reduce footprint

    Compare with previous version

  • Use -Bsymbolic-functions for your shared libraries. This tells the linker to use direct local jumps to symbols within your library instead of trying to resolve them by the usual means. The effect is that every function call within your library will be initially faster since there's no lookup required. This leads to faster load times.

    From https://wiki.qt.io/Performance_Tip_Startup_Time

  • changed milestone to %1.19.1

  • d k mentioned in issue gstreamer#1612

    mentioned in issue gstreamer#1612

  • Please register or sign in to reply
    Loading