Add update-orc-dist target

assigned to @gstreamer-merge-bot

mentioned in commit tpm/gst-build@ebf79cf7

added 1 commit

• ebf79cf7 - Add update-orc-dist target

Compare with previous version

merged

I'm getting this error with meson 0.54.999

meson.build:316:2: ERROR: alias_target takes at least 2 arguments.

Can you confirm the meson version you are using @tpm ?

0.54.3

Is this with up to date base/good/bad?

Are you disabling most plugins and opting in only to specific ones?

It sounds like the problem is that there are no orc targets in your setup.

Does this fix it for you?

diff --git a/meson.build b/meson.build
index dd35b4f..0e0c84f 100644
--- a/meson.build
+++ b/meson.build
@@ -312,6 +312,6 @@ run_target('git-update', command : [update])
 run_target('update', command : [update,
     '--builddir=@0@'.format(meson.current_build_dir())])
 
-if orc_subproject.found()
+if orc_subproject.found() and orc_update_targets.length() > 0
   alias_target('update-orc-dist', orc_update_targets)
 endif

After updating base and bad (working on a branch...), it works as orc_update_targets is not empty. Thanks for your quick support (as usual) :)

Concerning your patch, I dont know if it can happen again and if its a problem to not have this target, up to you ...

I think there are scenarios where update_targets can be legitimately empty, so will fix this up. Thanks for flagging it.

It's a convenience target for maintainers, there's no problem if it's not available.

mentioned in commit tpm/gst-build@f9f850f9

mentioned in merge request !173 (merged)

mentioned in commit tpm/gst-build@80976dea

changed milestone to %1.17.90