Enable Visual Studio variant by default on Windows, including for build tools

MSVC CI has been broken for a few days now while building cargo-c. At first this was happening randomly, but now it is very consistent. There has been some breakage in build.rs in some cargo-c dependencies (because we do not lock it down with a Cargo.lock unlike gst-plugins-rs; maybe we should) which is causing libz-sys, libssh-sys, and other crates to build C code with the wrong toolchain (MSVC instead of GNU).

I tried a lot of different fixes, but in the end the only thing that worked was moving to MSVC for building all build-tools. This makes our setup less special and makes such issues much less likely in the future.

This is a move that we've been wanting to make for a while anyway because we've been recommending the MSVC binaries for years since it integrates better with 99% of projects out there.

Our MinGW toolchain is also quite out of date and is lacking new features / APIs in Windows 10 and 11. However, we will continue to support it since there are still people that use MinGW on Windows.

---

There is a migration path where cerbero will refuse to run if you have a build-tools prefix which has been built with MinGW, and will tell you what commands to run to wipe and rebuild it.

added CI Rust Windows labels

added 1 commit

• 7890b606 - Use Visual Studio by default for building on Windows

Compare with previous version

approved this merge request

This might need some README updates probably?

added 2 commits

• 9985c1b9 - cerbero: Build pkg-config as a build-tool even with MSYS2
• e30ab60d - docs: Update README to reflect the new Visual Studio default

Compare with previous version

resolved all threads

assigned to @gstreamer-merge-bot

mentioned in commit nirbheek/cerbero@ee7116bb

mentioned in commit nirbheek/cerbero@68b7e6f0

mentioned in commit nirbheek/cerbero@b6d56a4a

mentioned in commit nirbheek/cerbero@f410fa02

mentioned in commit nirbheek/cerbero@7d82746c

added 5 commits

• b6d56a4a - cargo-c.recipe: Try to use the system zlib
• 68b7e6f0 - zlib.recipe: The && check in the patch is wrong
• ee7116bb - Use Visual Studio by default for building on Windows
• 7d82746c - cerbero: Build pkg-config as a build-tool even with MSYS2
• f410fa02 - docs: Update README to reflect the new Visual Studio default

Compare with previous version

assigned to @nirbheek and unassigned @gstreamer-merge-bot

I couldn't merge this branch: CI failed!

assigned to @gstreamer-merge-bot and unassigned @nirbheek

merged

changed milestone to %1.21.2

mentioned in merge request !659 (merged)