Skip to content

shell-utils: decode output on subprocess error

Tim-Philipp Müller requested to merge tpm/cerbero:shell-utils-decode-output-on-subprocess-error into main

Fixes python exception when printing output of failed subprocess:

File "/builds/gstreamer/cerbero/cerbero/build/recipe.py", line 326, in _get_la_deps_from_pc
    ret = shell.check_output(['pkg-config', '--libs-only-l', '--static', pcname], env=env, logfile=self.logfile)
  File "/builds/gstreamer/cerbero/cerbero/utils/shell.py", line 176, in check_output
    msg += '\nstderr in logfile {}'.format(logfile.name)
TypeError: can't concat str to bytes

See failed cerbero CI jobs in gstreamer!1244 (merged) for an example of this.

Edited by Tim-Philipp Müller

Merge request reports