Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • cerbero cerbero
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • cerberocerbero
  • Merge requests
  • !73

cerbero: Fix environment leakage between recipes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nirbheek Chauhan requested to merge nirbheek/cerbero:fix-env-leakage into master Jan 11, 2019
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 1

This bug was added in 461803fe

For env vars edited by the recipe, we shouldn't set the old_env to an incorrect value which also contains any changes made by the recipe. @modify_environment will take care to restore the original env when we return from the build step for those vars.

No idea why this wasn't caught earlier, an easy way to reproduce is to do buildone glib libusrsctp.

@ylatuya, this might also have been what you saw while updating the mingw toolchain in addition to the leak-env-on-exception bug.

Edited Jan 11, 2019 by Nirbheek Chauhan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-env-leakage