Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • cerbero cerbero
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 112
    • Issues 112
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 33
    • Merge requests 33
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • cerberocerbero
  • Merge requests
  • !555

cerbero: Read/write meson config files as utf-8

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nirbheek Chauhan requested to merge nirbheek/cerbero:recipe-files-utf8 into master Jul 18, 2020
  • Overview 0
  • Commits 1
  • Pipelines 4
  • Changes 1

The cross and native files should be written as utf-8 because that is what Meson expects, and we should read meson_options.txt as utf-8, because that is what it will always be.

Fixes the following error on macOS while reading meson_options.txt:

Traceback (most recent call last):
  File "cerbero/build/oven.py", line 451, in _cook_recipe_step
    await ret
  File "cerbero/build/recipe.py", line 82, in async_wrapped
    await stepfunc()
  File "cerbero/build/build.py", line 63, in async_call
    res = await func(*args)
  File "cerbero/build/build.py", line 1011, in configure
    self._set_option({'introspection', 'gir'}, 'gi')
  File "cerbero/build/build.py", line 771, in _set_option
    options = f.read()
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 12: ordinal not in range(128)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: recipe-files-utf8