Skip to content

Fix relocation and naming convention of libraries

amyspark requested to merge amyspark/cerbero:make-libpng-relocatable into main

Hi,

This MR fixes the issue where FindGStreamer would report the libpng include folder as missing:

C/C++: debug|x86_64 :CMake Warning at /builds/gstreamer/cerbero/cerbero-android-universal/x86_64/share/cmake/FindGStreamer.cmake:184 (message):
C/C++: debug|x86_64 :  Skipping missing include folder
C/C++: debug|x86_64 :  /builds/gstreamer/cerbero/cb/dist/android_universal/x86_64/include.
C/C++: debug|x86_64 :Call Stack (most recent call first):
C/C++: debug|x86_64 :  /builds/gstreamer/cerbero/cerbero-android-universal/x86_64/share/cmake/FindGStreamer.cmake:360 (_gst_filter_missing_directories)
C/C++: debug|x86_64 :  /builds/gstreamer/cerbero/cerbero-android-universal/x86_64/share/cmake/FindGStreamerMobile.cmake:328 (find_package)
C/C++: debug|x86_64 :  CMakeLists.txt:32 (find_package)

With many thanks to @ystreet for figuring out the reason.

See #368 -- this additionally fixes warnings when locating the following, and bundling into installers:

  • gst-plugins-rs
  • taglib
  • taglib_c
  • (hai)srt
  • libpng(16)
  • expat
  • libdts (and dca)
  • spandsp
  • zbar
  • libjpeg(-turbo)
  • openssl
  • nghttp2
  • x265
  • qrencode
  • expat
Edited by amyspark

Merge request reports