Skip to content

Fix gensdkshell

Nicolas Dufresne requested to merge ndufresne/cerbero:gensdkshell-fixes into master

This includes various fixes to gensdkshell.

  • Fix duplicate values in gst-env
  • Remove old 0.10 env
  • Add both plugin path to guaranty we use the right plugins

commit 143e6ff5:

gensdkshell: Copy input env dictionary
Dictionaries are mutable, callers don't expect their env to be modified.
On top of this, the default dictionary is instantiated once which will
have side effect on the second call.

This is noticeable when looking at the gst-env generate script. All the
env values are duplicated (duplicated path, duplicated flags, etc).

commit 59f028c4:

gensdkshell: Remove environment for 0.10 version

commit c4a5c681:

gensdkshell: Don't add arbitrary path to environments
These script are only suppose to add GStreamer specific path. This
removes systems path for which we have no impact on.

commit ad9204ee:

gensdkshell: Set both plugin path
While conceptually on installed system it makes sense to only set the
GST_PLUGIN_SYSTEM_PATH, in practice we have no choice but to set both
since the host system may have one of the other set already. Note
overriding both would lead to the wrong plugins being loaded.
Edited by Nicolas Dufresne

Merge request reports