Skip to content

modem-manager: use signaled calls to get cached location information

Andrey Skvortsov requested to merge skv/geoclue:fix-nmea-timeout into master

mm_modem_location_get_3gpp|cdma_bs|nmea perform explicit modem query. In some cases modem command queue gets full, so almost all location queries failed by timeout and location stops updating. At the same time modem-manager continues to send location updates over dbus further.

geoclue log in this case: Failed to get location from 3GPP: Timeout was reached Failed to get location from NMEA information: Timeout was reached Failed to get location from 3GPP: Timeout was reached Failed to get location from NMEA information: Timeout was reached

Unlike mm_modem_location_get_3gpp|cdma_bs|nmea signaled methods don't perform an explicit query. Since geoclue received from modem-manager signal that it new location is available it's not needed to make another explicit modem query, it's enough to read updated value from modem-manager using signaled methods.

Merge request reports