- Feb 15, 2018
-
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
- Feb 13, 2018
-
-
Víctor Manuel Jáquez Leal authored
vaapsink, when used with the Intel VA-API driver, tries to display surfaces with format NV12, which are handled correctly by Weston. Nonetheless, COGL cannot display YUV surfaces, making fail pipelines on mutter. This shall be solved either by COGL or by making the driver to paint RGB surfaces. In the meanwhile, let's just demote vaapisink as marginal when the Wayland environment is detected, no matter if it is Weston. https://bugzilla.gnome.org/show_bug.cgi?id=775698
-
Víctor Manuel Jáquez Leal authored
Mesa has updated its VA-API Gallium driver vendor string: https://cgit.freedesktop.org/mesa/mesa/commit/?id=5db29d62ce1fefa3f2ee6e4a4688576fde4bde4a This patch tries to cover both, the old and the new one. https://bugzilla.gnome.org/show_bug.cgi?id=793386
-
- Feb 08, 2018
-
-
Tim-Philipp Müller authored
WARNING: Trying to compare values of different types (str, int). The result of this is undefined and will become a hard error in a future Meson release.
-
Víctor Manuel Jáquez Leal authored
In propose_allocation() if the numer of allocation params is zero, the system's allocator is added first, and lastly the native VA-API allocator. In decide_allocation(), the allocations params in query are travered, looking for a native VA-API allocator. If it is found, it is reused as src pad allocator. Otherwise, a new allocator is instantiated and appended in the query. https://bugzilla.gnome.org/show_bug.cgi?id=789476
-
- Feb 07, 2018
-
-
Víctor Manuel Jáquez Leal authored
GST_VAAPI_VIDEO_ALLOCATOR_NAME was added in commit 5b11b833 but it was never used, since the native VA-API allocator name has been GST_VAAPI_VIDEO_MEMORY_NAME. This patch removes GST_VAAPI_VIDEO_ALLOCATOR_NAME macro. https://bugzilla.gnome.org/show_bug.cgi?id=789476
-
- Feb 05, 2018
-
-
Don't subscribe to button press events when using a foreing window, because the user created window would trap those events, preveting the show of frames. https://bugzilla.gnome.org/show_bug.cgi?id=791615
-
-
- Jan 30, 2018
-
-
-
Philippe Normand authored
The array needs to be NULL-terminated according to the gst_plugin_add_dependency() documentation.
-
- Jan 18, 2018
-
-
Víctor Manuel Jáquez Leal authored
This assignation is dead code, since gst_video_info_from_caps() set to 1 by default. https://bugzilla.gnome.org/show_bug.cgi?id=790149
-
Víctor Manuel Jáquez Leal authored
Instead of copying the pixel-aspect-ratio from the sink caps, define an open range for the src caps pixel-aspect-ratio. Later it will be defined. https://bugzilla.gnome.org/show_bug.cgi?id=790149
-
Víctor Manuel Jáquez Leal authored
Check for display's color-balance properties, available by the VA-API driver, before setting them. Also logs an info message of those unavailable properties. https://bugzilla.gnome.org/show_bug.cgi?id=792638
-
- Jan 17, 2018
-
-
Víctor Manuel Jáquez Leal authored
at propose_allocation() we should not reuse the proposed buffer, because it could break renegotiation. https://bugzilla.gnome.org/show_bug.cgi?id=792620
-
-
Víctor Manuel Jáquez Leal authored
-
Víctor Manuel Jáquez Leal authored
-
- Jan 16, 2018
-
-
Víctor Manuel Jáquez Leal authored
Remove the hack to check if an upstream element has enabled the property io-mode enabled as dmabuf-import. https://bugzilla.gnome.org/show_bug.cgi?id=792034
-
- Jan 12, 2018
-
-
Víctor Manuel Jáquez Leal authored
eglGetDisplay() is currently broken in Mesa for Wayland. Also using eglGetDisplay() is rather fragile, and it is recommended to use eglGetPlatformDisplay() when possible. In order to do that, this patch uses the helper in GstGL. If gstreamer-vaapi is not compiled with GstGL support, eglGetDisplay() will be used. https://bugzilla.gnome.org/show_bug.cgi?id=790493
-
gst_vaapipostproc_ensure_filter might free the allowed_srcpad_caps and allowed_sinkpad_caps. This can race with copying these caps in gst_vaapipostproc_transform_caps and lead to segfaults. The gst_vaapipostproc_transform_caps function already locks postproc_lock before copying the caps. Make sure that calls to gst_vaapipostproc_ensure_filter also acquire this lock. https://bugzilla.gnome.org/show_bug.cgi?id=791404
-
- Jan 10, 2018
-
-
Víctor Manuel Jáquez Leal authored
Null-checking op_info suggests that it may be null, but it has already been dereferenced on all paths leading to the check. There may be a null pointer dereference, or else the comparison against null is unnecessary.
-
Víctor Manuel Jáquez Leal authored
str cannot be null in that moment, but it may be the end of string.
-
Víctor Manuel Jáquez Leal authored
Assigning the return value of fgetc to char truncates its value. It will not be possible to distinguish between EOF and a valid character.
-
Víctor Manuel Jáquez Leal authored
Passed pointer in parse_int() are unsigned int (32 bits, unsigned) but they are dereferenced as a wider long (64 bits, signed). This may lead to memory corruption.
-
- Dec 19, 2017
-
-
Tim-Philipp Müller authored
-
- Dec 14, 2017
-
-
Matthew Waters authored
From e8c7a71 to 3fa2c9e
-
- Dec 06, 2017
-
-
Nicolas Dufresne authored
For this reson we need not to unref the message, even if it failed.
-
Nicolas Dufresne authored
This reverts commit 0438a3e6.
-
Víctor Manuel Jáquez Leal authored
-
Víctor Manuel Jáquez Leal authored
-
- Dec 01, 2017
-
-
Víctor Manuel Jáquez Leal authored
gst.vaapi.app.Display context is made for applications that will provide the VA display and the native display to used by the pipeline, when are using vaapisink as overlay. There are no use case for encoders, decoders, neither for the postprocessor. In the case of the vaapisink, it shall query for gst.vaapi.Display upstream first, and then, if there is no reply, gst.vaapi.app.Display context will be posted in the bus for the application. If the application replies, a GstVaapiDisplay object is instantiated given the context info, otherwise a GstVaapiDisplay is created with the normal algorithm to guess the graphics platform. Either way, the instantiated GstVaapiDisplay is propagated among the pipeline and the have-message bus message. Also only vaapisink will process the gst.vaapi.app.Display, if and only if, it doesn't have a display already set. This is caused because if vaapisink is in a bin (playsink, for example) the need-context is posted twice, leading to an error state. https://bugzilla.gnome.org/show_bug.cgi?id=790999
-
-
-
- Nov 27, 2017
-
-
Víctor Manuel Jáquez Leal authored
Remove wayland-client.h include since there is no exposed symbols from it.
-
Víctor Manuel Jáquez Leal authored
macroblock parameter appear on VA-API 1.0.0. It should be guarded.
-
Matthew Waters authored
From 3f4aa96 to e8c7a71
-
- Nov 08, 2017
-
-
Frames are encoded as different layers. Frame in a particular layer will use pictures in lower or same layer as references. Which means decoder can drop the frames in upper layer but still decode lower layer frames. B-frames, except the one in top most layer, are reference frames. All the base layer frames are I or P. eg: with 3 temporal layers T3: B1 B3 B5 B7 T2: B2 B6 T1: I0 P4 P8 T1, T2, T3: Temporal Layers P1...Pn: P-Frames: B1...Bn: B-frames: T1: I0->P4 , P4->P8 etc.. T2: I0--> B2 <-- P4 T3: I0--> B1 <-- B2, B2 --> B3 <-- P4 Signed-off-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com> https://bugzilla.gnome.org/show_bug.cgi?id=788918
-
Frames are encoded as different layers. A frame in a particular layer will use pictures in lower or same layer as references. Which means decoder can drop the frames in upper layer but still decode lower layer frames. eg: with 3 temporal layers T3: P1 P3 P5 P7 T2: P2 P6 T1: P0 P4 P8 T1, T2, T3: Temporal Layers P1...pn: P-Frames: P0->P1 , P0->P2, P2->P3, P0->P4......repeat Signed-off-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com> https://bugzilla.gnome.org/show_bug.cgi?id=788918
-
The frame_num generation was not correctly implemented. According to h264 spec, frame_num should get incremented for each frame if previous frame is a referece frame. For eg: IPBPB sequece should have the frame numbers 0,1,2,2,3 Signed-off-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com> https://bugzilla.gnome.org/show_bug.cgi?id=788918
-