Skip to content

enable custom_build_dir for dockers runners

Benjamin Tissoires requested to merge bentiss/helm-gitlab-infra:wip/custom_build_dir into master

See https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4203

Custom build dir is useful for go packages: https://docs.gitlab.com/ee/ci/runners/README.html#custom-build-directories

It is supposed to be enabled by default on docker (because the path has to be under $CI_BUILDS_DIR): https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnerscustom_build_dir-section

But when generating the config, the gitlab runner register script created the section, but omitted the enabled setting. However, in that case, gitlab runner interprets this as false when the doc says it should be true for docker executor.

I am opening the discussion here to check with others if this is safe to apply.

I personally think it is.

Note that we still need to manually enable the setting in the existing runners, but a MR is a nice place to have such public discussion.

Cc: @daniels

Merge request reports