Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
F
fontconfig
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 152
    • Issues 152
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • fontconfig
  • fontconfig
  • Merge Requests
  • !91

Open
Opened Apr 01, 2020 by Caleb Hearon@chearon
  • Report abuse
Report abuse

Skip ja or zh-tw if one of them is exclusive - fixes a loop that had no effect

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

Hello FontConfig team,

I've been working on a WASM port of FontConfig and as I was working on it, I came across this loop that effectively doesn't do anything. I believe the continue is supposed to break out of the outer loop and skip adding the current language to the font.

Breaks out of the correct loop in e50b9ae7, wrong loop in cd2ec1a9

The loop only runs when someone specifies an exclusiveLang of ja or zh-tw, and I haven't found any fonts where that would matter (i.e., my Japanese fonts don't cover traditional Chinese, and vice versa). So I'm not sure if this would have an effect for any fonts or not, but it looked like it should be corrected somehow.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: fontconfig/fontconfig!91
Source branch: exclusive-lang-loop