Skip to content

Check qual and compare for family tests

Szunti requested to merge Szunti/fontconfig:fix267 into master

Fixes #267 (closed). Hash table lookups assumed qual="any" compare="eq".

If there is a match, then the value list is walked again to get the position for match-relative edits. But for FcQualAll matches the location of the match is not that useful and this second walk could be eliminated. But this would change the current behaviour of returning the last element's position.

Maybe it would be cleaner to not return a position with FcQualAll matches and allow only non-relative edits.

Merge request reports