- May 29, 2019
-
-
Tim-Philipp Müller authored
- May 16, 2019
-
-
In 2018 khronos changed the gl header guards. If we don't detect this properly we would end up with plenty of symbol redifinition (since we would be importing twice the "same" header). Instead detect if the "newer" header was already included and if so define the "old" define to avoid this situation Fixes #523
-
Nirbheek Chauhan authored
Fixes a build error with the latest macOS: libtool: compile: unable to infer tagged configuration libtool: error: specify a tag with '--tag'
-
- May 06, 2019
-
-
Only forward the marker for the last NAL of the STAP-A. Otherwise each NAL endup being assumed to be a full frame which may break rendering. Fixes 557
-
When multiple nals are aggrgated, the marker bit should be associated only with the last NAL of the packet. Otherwise we may break rendering in with AU alignment.
-
Library existence does not guarantee header.
-
The cdata structure was freed but not its caps. It was already done in gst_v4l2_video_dec_subclass_init() and gst_v4l2_video_enc_subclass_init().
-
-
While forwarding serialized event, we use gst_pad_forward() function. In the forward callback (GstPadForwardFunction) we always return TRUE. Returning true there will stop the dispatching procedure. As a side effect, only one events is receiving the events. This breaks when sending EOS from the applicaiton, it also breaks the latency tracer.
-
We expect there to be a pool as long as the caps are known and FLUSH_STOP is not resetting the caps. Getting rid of the pool would cause assertions. Fixes gstreamer/gst-plugins-good#584
-
-
Port objects acquired with jack_get_ports() need to be freed with jack_free(3), not stdlib free(). On Windows, Jack may be linked against different libc than GStreamer libraries so free()ing port objects directly might cause crash because of libc mismatch.
-
The sink_event parent function may consume the event so we shouldn't use it after having calling it.
-
-
-
This can happen in various error cases that could happen between the creation of the element in question and the adding to the rtspsrc. It causes an ugly critical warning right now but is otherwise harmless.
-
This fixes a critical warning if the last-sample property is enabled: (gst-launch-1.0:391): GStreamer-CRITICAL **: 01:12:57.428: gst_object_unref: assertion 'object != NULL' failed If the allocation query does not contain any allocation pools, gst_query_parse_nth_allocation_pool will leave the local pool, min, and max variables undefined, so check the array length first. If pool is NULL, do not call gst_object_unref.
-
-
-
The deprecated debug visualizer was removed.
-
It is possible that PulseAudio adds formats that are not yet supported in pulsesink, and in those cases, we want to gracefully skip them rather than cause an assert on a NULL caps.
-
And let it the oportunity to get its other pad linked Example: ``` $ gst-launch-1.0 uridecodebin uri=file:///home/thiblahute/gst-validate.save/gst-integration-testsuites/testsuites/../medias/defaults/flv/819290236.flv caps=audio/x-raw expose-all-streams=FALSE ! fakesink Setting pipeline to PAUSED ... Pipeline is PREROLLING ... ERROR: from element /GstPipeline:pipeline0/GstURIDecodeBin:uridecodebin0/GstDecodeBin:decodebin0/GstFlvDemux:flvdemux0: Internal data stream error. Additional debug info: ../subprojects/gst-plugins-good/gst/flv/gstflvdemux.c(2760): gst_flv_demux_loop (): /GstPipeline:pipeline0/GstURIDecodeBin:uridecodebin0/GstDecodeBin:decodebin0/GstFlvDemux:flvdemux0: streaming stopped, reason not-linked (-1) ERROR: pipeline doesn't want to preroll. Setting pipeline to NULL ... Freeing pipeline ... ```
-
Modify the caps string to allow width and height greater than 4096. There is no need to restrict it since the matroska format allows the width and height values to be up to eight bytes long, and this also applies to the webm subset of the format. Fixes gstreamer/gst-plugins-good#550
-
It makes no sense for a decoder to output a BYTES segment, and many elements one would plug downstream of a video decoder assume the segments they receive are in TIME format, for example this fixes: gst-validate-1.0 filesrc location=opacity01.svg ! gdkpixbufdec ! \ videobalance ! videoconvert ! fakesink In that case, videobalance was emitting an assertion when trying to call gst_object_sync_values()
-
-
PA_INVALID_INDEX, the default value, is unfortunately !0. Setting the volume before the stream is created will put the ring buffer in error state. Unfortunately, that's what spice-gtk does.
-
Don't forget to free returned memory from _search_pos()
-
The duration field being a uint64, is stored in 8 bytes, not 4. So the offset of the following field, language code, needs to be updated accordingly so that the parsed language code is not garbage.
-
kAudioFormatFlagIsSignedInteger is a format flags Closes #394
-
The teardown of the pads checks the refcount, but there are timers inside the jitterbuffer that can push things, so if we're not lucky, things could be pushed while the pads are being shut down. Putting the jitterbuffer to NULL first avoids this.
-
- May 01, 2019
-
-
Pass riff codec-data as strf, not strd, which is where gst_riff_create_audio_caps() expects the WAVEFORMATEXTENSIBLE data. https://bugzilla.gnome.org/show_bug.cgi?id=757583 Fixes #234
-
-
Otherwise it might lead to deadlocks See https://gitlab.gnome.org/GNOME/pitivi/issues/2259 Closes #518
-
Tim-Philipp Müller authored
This is an enum not a boolean, and a value of 2 signals that the video is progressive, but we would mistakenly set interlace-mode=mixed on the output caps. https://bugzilla.gnome.org/show_bug.cgi?id=787206
-
-
Tim-Philipp Müller authored
Strip ADTS headers if we detect any, apparently some Sony cameras send AAC with ADTS headers. We could also change the stream-format in the output caps, but that would be unexpected to pipeline builders and would not exactly be backwards compatible.
-
Use gst_buffer_replace() to prevent buffer leak https://bugzilla.gnome.org/show_bug.cgi?id=797179
-
- Mar 12, 2019
-
-
Exposed by rtp_h264depay_bytestream() unit test.
-