Skip to content
  • Mario Kleiner's avatar
    dri3: Fix error handling in dri3_buffer_from_pixmap request. · fbc5c5cd
    Mario Kleiner authored and Adam Jackson's avatar Adam Jackson committed
    The old info->fd_from_pixmap() driver hook, which is
    preferentially used in dri3_fd_from_pixmap(), can return
    error codes other than -1, e.g., -EINVAL (-22) on nouveau-ddx.
    
    Not handling the error causes a broken/corrupted X-Connection
    resulting from a failed request.
    
    This fixes failure of sddm-greeter to start up under nouveau-ddx
    with DRI3 enabled and DRI3 protocol version properly clamped
    to 1.0 by the server (see followup patch).
    
    Fixes: 75bba3ae
    
     ("dri3: Use single-FD screen call for single-FD request")
    Signed-off-by: default avatarMario Kleiner <mario.kleiner.de@gmail.com>
    Reviewed-by: default avatarAdam Jackson <ajax@redhat.com>
    Cc: Daniel Stone <daniels@collabora.com>
    fbc5c5cd