- Aug 07, 2017
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
- Aug 04, 2017
-
-
We don't want to advertise experimental extensions in actual releases. However, there's no harm in leaving the code lying around in the tree.
-
X/GLX can't handle them. This removes almost 500 GLX visuals that were incorrectly exposed. This is a less invasive version of Marek's .getCapability series. Note: the patch is not applicable for master, but only for the 17.2 branch. Suggested-by:
Marek Olšák <marek.olsak@amd.com> Signed-off-by:
Tomasz Figa <tfiga@chromium.org> CC: <mesa-stable@lists.freedesktop.org> Fixes: f33d8af7 "st/dri: add 32-bit RGBX/RGBA formats" [Emil Velikov: commit message polish] Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-
Copy/paste error was duplicating a gen_knobs.cpp rule. Fixes: 5079c277 ("swr: [scons] Fix windows build") Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Bruce Cherniak <bruce.cherniak@intel.com> (cherry picked from commit e4a6ae06)
-
Reported by valgrind at: glsl_to_tgsi_visitor::visit(ir_expression*) (st_glsl_to_tgsi.cpp:1560) When compiling the Deus Ex shaders. Fixes: 28a5e710 ("st/glsl_to_tgsi: handle precise modifier") Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> Reviewed-by:
Karol Herbst <karolherbst@gmail.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 06237fc9)
-
GLES/gl.h has historically provided some typedefs that are not used in the API itself. Restore these typedefs that were lost to avoid breaking applications. These seem to be the only typedefs removed in the update. Fixes: 7fd08177 "Update Khronos-supplied headers" [Eric: added a big warning to revert this patch when pulling the updated header] Signed-off-by:
Eric Engestrom <eric.engestrom@imgtec.com> (cherry picked from commit 3db05ed1)
-
This reverts commit 3008161d, which caused a regression for VMWare. The initial code had some recursion in it, that I removed by accident trying to add back the recursion broke lots of things, take the high road and revert for now. Fixes: 3008161d (st_glsl_to_tgsi: rewrite rename registers to use array fully.) Reviewed-by:
Brian Paul <brianp@vmware.com> Tested-by:
Brian Paul <brianp@vmware.com> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit b8bea9a0)
-
This fixes: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.* for a2r10g10b10 formats as destination on SI/CIK hardware. This adds support to the meta program for emitting 10-bit outputs, and adds 10-bit support to the fragment shader key. It also only does the int8/10 on SI/CIK. Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit df61a050)
-
In some APU situations the reported visible size can be larger than VRAM size. This properly clamps the value. Surprisingly both CTS and spec seem to allow a heap type with size 0, so this seemed like the easiest option to me. Signed-off-by:
Bas Nieuwenhuizen <basni@google.com> Fixes: 4ae84efb "radv: Use enum for memory heaps." Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Tested-by:
Michel Dänzer <michel.daenzer@amd.com> (cherry picked from commit 8229706a)
-
Commit bbc29393 didn't include osmesa state_tracker. This patch adds necessary initialization. Fixes crash in OSMesa initialization. Created-by:
Charmaine Lee <charmainel@vmware.com> Tested-by:
Bruce Cherniak <bruce.cherniak@intel.com> Reviewed-by:
Charmaine Lee <charmainel@vmware.com> Cc: 17.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 9966c85e)
-
If dual object compile fails (as seems to happen with virgl a fair bit, and does piglit even have any tests for it?), we end up not restarting the pull params, so we call vec4_visitor::move_uniform_array_access_to_pull_constant a second time and it runs over the ends of the alloc. Fixes: tests/spec/glsl-1.50/execution/geometry/max-input-components.shader_test running inside virgl on ivybridge. Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 271fa3a6)
-
Remember to add the offset to the start of the buffer in the relocation or else we write 0xff into random bytes elsewhere. Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit fb63c43f)
-
The cacheline alignment restriction is on the base address; the pitch can be anything. Fixes assertion failures when using primus (say, on glxgears, which creates a 300x300 linear BGRX surface with a pitch of 1200): intel_blit.c:190: get_blit_intratile_offset_el: Assertion `mt->surf.row_pitch % 64 == 0' failed. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Chris Wilson <chris@chris-wilson.co.uk> (cherry picked from commit 595a47b8)
-
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: "17.1 17.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 95c6a974)
-
This implements a wait for glXWaitGL, glXCopySubBuffer, dri flush_front and creation of fake front until all pending SwapBuffers have been committed to hardware. Among other things this fixes piglit glx-copy-sub-buffers on dri3. Signed-off-by:
Thomas Hellstrom <thellstrom@vmware.com> Reviewed-by:
Brian Paul <brianp@vmware.com> Reviewed-by:
Sinclair Yeh <syeh@vmware.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Cc: <mesa-stable@lists.freedesktop.org> (cherry picked from commit 185ef06f)
-
The issue here is that the immediate is treated as a 64-bit value, and fetching it does not work reliably with swizzles that are different from xy and zw. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit da83687c)
-
This looks like it's supported since llvm 3.9 at least, so switch over radeonsi and radv to using it, -pro also uses this. We can now drop creating lds for these operations as the ds_swizzle operation doesn't actually write to lds at all. Acked-by:
Marek Olšák <marek.olsak@amd.com> (stable requested due to fixing radv CIK conformance tests) Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit cb6f16dc) [Emil Velikov: resolve trivial conflicts] Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Conflicts: src/amd/common/ac_nir_to_llvm.c
-
This makes it match radeonsi. The LLVM backend itself will emit the correct instruction, but LLVM might do incorrect optimizations since it thinks the output is undefined when the input is 0, even though it's not supposed to be. We really need a new intrinsic, or for the backend to become smarter and recognize this pattern. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Bas Nieuwenhuizen <basni@google.com> (cherry picked from commit 6d731c56)
-
The optimizations are only valid for 32-bit integers. They were mistakenly firing for 64-bit integers as well. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit de914615)
-
This reverts commit 5c124126. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101961 Cc: 17.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit d85802e5)
-
Otherwise, code generation fails. This has become necessary since some shaders are wrapped in control flow. Fixes: 081ac6e5 ("radeonsi/gfx9: always wrap GS and TCS in an if-block (v2)") Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 2879a602)
-
The slower convert-and-copy process performs a bad conversion because it converts the value to signed 64-bit integer, but bindless uniform handles are considered unsigned 64-bit. This fixes "Check glUniform*() with mixed texture units/handles" from arb_bindless_texture-uniform piglit. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: "17.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit b38c9c57)
-
- Jul 31, 2017
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Since array splitting for AoA is disabled, we have to retrieve the type of the first non-array type when an array of images is declared inside a structure. Otherwise, it will hit an assert in glsl_type::sampler_index() because it expects either a sampler or an image type. This fixes a regression in the following piglit test: arb_bindless_texture/compiler/images/arrays-of-struct.frag Fixes: 57165f2e ("glsl: disable array splitting for AoA") Cc: 17.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit f99e9335)
-
Noticed randomly. Cc: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit 5c124126)
-
On SI this was causing a hang in dEQP-VK.pipeline.render_to_image.core.2d_array.mipmap.r16g16_sint_s8_uint This was due to not handling the tile mode index for depth like I fixed previously for new GPUs. Fixes: 01d0c5a9 (radv: fix stencil regression since new addrlib import) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 800d1622)
-
The host doesn't understand this yet, so drop it for now. Fixes: virgl regressions. Fixes: af22adee (tgsi: add precise flag to tgsi_instruction) Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 554aa094)
-
This fixes corruption with bindless textures in Dawn Of War 3. The do_update_surf_dirtiness mechanism was complicated and dirty_level_mask was only updated after the first draw call. The problem is bindless textures are checked for decompression every draw call and we would only decompress after the first draw call. The solution is to set dirtiness after the last draw call to the framebuffer, so the (unconditional) decompression of bindless textures happens at the right time. Cc: 17.2 <mesa-stable@lists.freedesktop.org> Tested-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit f4d095cc)
-
This fixes the black Feral launcher window. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867 Cc: 17.2 <mesa-stable@lists.freedesktop.org> Tested-by:
Edmondo Tommasina <edmondo.tommasina@gmail.com> (cherry picked from commit 7257c171)
-
With merged ESGS shaders, the GS part of a wave may be empty, and the hardware gets confused if any GS messages are sent from that wave. Since S_SENDMSG is executed even when EXEC = 0, we have to wrap even non-monolithic GS shaders in an if-block, so that the entire shader and hence the S_SENDMSG instructions are skipped in empty waves. This change is not required for TCS/HS, but applying it there as well simplifies the logic a bit. Fixes GL45-CTS.geometry_shader.rendering.rendering.* v2: ensure that the TCS epilog doesn't run for non-existing patches Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 081ac6e5)
-
Cc: mesa-stable@lists.freedesktop.org Reviewed: Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 87378900)
-
The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout or SO shader) was not using the correct offsets. Adjust the offsets that are used just for the SO shader: - Make sure that position is handled in the same special way as in the vs/gs shaders - Use the correct offset to be passed in the core - consolidate register slot mapping logic into one function, since it's been calculated in 2 different places (one for calcuating the slot mask, and one for the register offsets themselves Also make room for all attibutes in the backend vertex area. Fixes: - all vtk GL2PS tests - 18 piglit tests (16 ext_transform_feedback tests, arb-quads-follow-provoking-vertex and primitive-type gl_points v2: - take care of more SGV slots in slot mapping logic - trim feState.vsVertexSize - fix GS interface and incorporate GS while calculating vsVertexSize Note that vsVertexSize is used in the core as the one parameter that controls vertex size between all stages, so it has to be adjusted appropriately for the whole vs/gs/fs pipeline. Also note that GS and SO is not fully implemented. This will be addressed later. fixes: - fixes total of 20 piglit tests CC: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Bruce Cherniak <bruce.cherniak@intel.com> (cherry picked from commit 194ff5ee)
-
- Jul 27, 2017
-
-
This ports 72e46c98 to radv. radeonsi: apply a TC L1 write corruption workaround for SI Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit e77ff11f)
-
This ports: da745366 radeonsi: don't apply the Z export bug workaround to Hainan to radv. Just noticed in passing. Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit a81e99f5)
-
Until we support sync fd, don't report the info. Fixes CTS dEQP-VK.api.external.semaphore.sync_fd.* from crashing. Fixes: eaa56eab (radv: initial support for shared semaphores (v2)) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 6cbc8cf1)
-
Fixes CTS dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.1024 on SI/CIK with radv. Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit ca82ef5a)
-
Always initialise whandle.modifier for DRIImage modifier queries, so if the driver doesn't support it then we return false for the query. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Fixes: d33fe8b8 ("st/dri: enable DRIimage modifier queries") (cherry picked from commit 45383d32)
-
In the DRIImage queryImage hook, check if resource_get_handle() failed and return FALSE if so. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit b4a18f13)
-
If the underlying driver does not support modifiers, dmabuf will still advertise formats through the 'modifier' event, but send them with an invalid modifier. Ignore them if this is the case, rather than passing them through to the driver. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Fixes: 02cc3593 ("egl/wayland: Use linux-dmabuf interface for buffers") (cherry picked from commit dd072cf4)
-
gcc prior to 4.9 didn't implement <regex>, causing a startup crash in the swr knob parameter reading code. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Bruce Cherniak <bruce.cherniak@intel.com> (cherry picked from commit e21fc2c6)
-