- Jun 14, 2015
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com>
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com>
-
- Jun 12, 2015
-
-
As we use the file from both the dri modules and loader, we end up with multiple definition of the symbols provided in our gallium dri modules. Additionally we compile the file twice. Resolve both issues, effectively enabling the build on toolchains which don't support -Wl,--allow-multiple-definition. v2: [Emil Velikov] - Fix the Scons/Android build. - Resolve libgbm build issues (bring back the missing -lm) Cc: Julien Isorce <j.isorce@samsung.com> Cc: "10.5 10.6" <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90310 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90905 Acked-by:
Matt Turner <mattst88@gmail.com> Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> (cherry picked from commit 634f2002)
-
Emil Velikov authored
Based on commit 101142c4(xa: support for drivers which use NIR) Cc: "10.6" <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90466 Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> (cherry picked from commit 83b5648a)
-
Emil Velikov authored
Based on commit 101142c4(xa: support for drivers which use NIR) Cc: Rob Clark <robclark@freedesktop.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90466 Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> (cherry picked from commit ba512cc7)
-
Emil Velikov authored
Rather than forcing everyone to provide their own definition of the symbol provide a common (dummy) one. This helps us resolve the build of the standalone pipe-drivers (amongst others), which are missing the symbol. Cc: Rob Clark <robclark@freedesktop.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> (cherry picked from commit 1df5a6c7)
-
Emil Velikov authored
Cc: Rob Clark <robclark@freedesktop.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> (cherry picked from commit 3f5dc9b9)
-
From ARB_program_interface_query: "Note that if an interface enumerates a single active resource list entry for an array variable (e.g., "a[0]"), a <name> identifying any array element other than the first (e.g., "a[1]") is not considered to match." It doesn't apply to arrays of interface blocks but just to array variables. Signed-off-by:
Samuel Iglesias Gonsalvez <siglesias@igalia.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> (cherry picked from commit 4ee69a97)
-
we don't check the validity of pscreen until dri_init_screen_helper hit this trying to init glamor on a device with no driver (udl). Acked-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 563706c1)
-
Some hardware reads only the low 16-bits even if the type is UD, but other hardware like Cherryview can't handle this. Fixes spec@arb_gpu_shader5@execution@sampler_array_indexing@fs-simple on Cherryview. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90830 Reviewed-by:
Neil Roberts <neil@linux.intel.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> (cherry picked from commit d46d0452)
-
When calculating the binding table index for non-constant sampler array indexing it needs to add the base binding table index which is a constant within the generated code. Often this base is zero so we can avoid a redundant instruction in that case. It looks like nothing in shader-db is doing non-constant sampler array indexing so this patch doesn't make any difference but it might be worth having anyway. Reviewed-by:
Matt Turner <mattst88@gmail.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> Acked-by:
Ben Widawsky <ben@bwidawsk.net> (cherry picked from commit 7f62fdae)
-
Previously when generating the send instruction for a sample instruction with an indirect sampler it would use the destination register as a temporary store. This breaks when used in combination with the opt_sampler_eot optimisation because that forces the destination to be null. This patch fixes that by avoiding the temp register altogether. The reason the temporary register was needed was because it was trying to ensure the binding table index doesn't overflow a byte by and'ing it with 0xff. The result is then or'd with samper_index<<8. This patch instead just and's the whole thing by 0xfff. This will ensure that a bogus sampler index won't overflow into the rest of the message descriptor but unlike the previous code it won't ensure that the binding table index doesn't overflow into the sampler index. It doesn't seem like that should matter very much though because if the shader is generating a bogus sampler index then it's going to just get garbage out either way. Instead of doing sampler_index<<8|(sampler_index+base_table_index) the new code avoids one operation by doing sampler_index*0x101+base_table_index which should be equivalent. However if we wanted to avoid the multiply for some reason we could do this by adding an extra or instruction still without needing the temporary register. This fixes a number of Piglit tests on Skylake that were using indirect samplers such as: spec@arb_gpu_shader5@execution@sampler_array_indexing@fs-simple Reviewed-by:
Matt Turner <mattst88@gmail.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> Acked-by:
Ben Widawsky <ben@bwidawsk.net> Tested-by:
Anuj Phogat <anuj.phogat@gmail.com> (cherry picked from commit 6c846dc5)
-
AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before the single send optimization we'd always bail because we hit the is_immediate && !is_compactable_immediate case. However, with single send, is_immediate is not true, and so we end up trying to compact the un-compactible. Without this, any compacting single send instruction will hang because the EOT isn't there. I am not sure how I didn't hit this when I originally enabled the optimization. I didn't check if some surrounding code changed. I know Neil and Matt were both looking into this. I did a quick search and didn't see any patches out there to handle this. Please ignore if this has already been sent by someone. (Direct me to it and I will review it). Reported-by:
Neil Roberts <neil@linux.intel.com> Reported-by:
Mark Janes <mark.a.janes@intel.com> Tested-by:
Mark Janes <mark.a.janes@intel.com> Signed-off-by:
Ben Widawsky <ben@bwidawsk.net> Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit b307921c)
-
Correct a regression introduced by commit 922c0c9f by converting "array format", if received from _mesa_format_from_format_and_type, to mesa_format. References: https://bugs.freedesktop.org/show_bug.cgi?id=90839 Signed-off-by:
Alexander Monakov <amonakov@gmail.com> Tested-by:
AnAkkk <anakin.cs@gmail.com> Reviewed-by:
Jason Ekstrand <jason.ekstrand@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit bd38f91f)
-
In commit fe74fee8 we rounded the line width to the nearest integer to match the GLES3 spec requirements stated in section 13.4.2.1, but that seems to break a dEQP test that renders wide lines in some multisampling scenarios. Ian noted that the Open 4.4 spec has the following similar text: "The actual width of non-antialiased lines is determined by rounding the supplied width to the nearest integer, then clamping it to the implementation-dependent maximum non-antialiased line width." and suggested that when ES removed antialiased lines, they removed "non-antialised" from that paragraph but probably should not have. Going by that note, this patch restricts the quantization implemented in fe74fee8 only to regular aliased lines. This seems to keep the tests fixed with that commit passing while fixing the broken test. v2: - Drop one of the clamps (Ken, Marius) - Add a rule to prevent advertising line widths that when rounded go beyond the limits allowed by the hardware (Ken) - Update comments in the code accordingly (Ian) - Put the code in a utility function (Ian) Fixes: dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_max.primitives.lines_wide Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90749 Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit f9a18acb)
-
When we import a dma-buf fd from another driver the kernel gives us the right info, and this trashes it. Convert the kernel bo flags into the domain flags. This helps getting reverse prime and glamor working. Cc: mesa-stable@lists.freedesktop.org Acked-by:
Ben Skeggs <bskeggs@redhat.com> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit c6877c9e)
-
Previously, we just put the message for the EOT send as high in the file as it would go. This is because the register pre-filling hardware will stop all over the early registers in the file in preparation for the next thread while you're still sending the last message. However, if something happens to spill, then the MRF hack interferes with the EOT send message and, if things aren't scheduled nicely, will stomp on it. Cc: "10.5 10.6" <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90520 Reviewed-by:
Neil Roberts <neil@linux.intel.com> (cherry picked from commit 86e5afbf)
-
Since the introduction of commit 536003c1 Author: Boyan Ding <boyan.j.ding@gmail.com> Date: Wed Mar 25 19:36:54 2015 +0800 i965: Add XRGB8888 format to intel_screen_make_configs winsys buffers no longer have an alpha channel. This causes _mesa_format_matches_format_and_type() to reject previously working BGRA uploads from using the BLT fast path. Instead of using the generic routine for matching formats exactly, export the slightly more relaxed check from intel_miptree_blit() which importantly allows the blitter routine to apply a small number of format conversions. References: https://bugs.freedesktop.org/show_bug.cgi?id=90839 Signed-off-by:
Chris Wilson <chris@chris-wilson.co.uk> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Alexander Monakov <amonakov@gmail.com> Cc: Kristian Høgsberg <krh@bitplanet.net> Cc: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 922c0c9f)
-
The blitter already has code to accommodate filling in the alpha channel for BGRX destination formats, so expand this to also allow filling the alpha channgel in RGBX formats. More importantly for the next patch is moving the test into its own function for the purpose of exporting the check to the callers. v2: Fix alpha expansion as spotted by Alexander with the fix suggested by Kenneth Signed-off-by:
Chris Wilson <chris@chris-wilson.co.uk> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Alexander Monakov <amonakov@gmail.com> Cc: Kristian Høgsberg <krh@bitplanet.net> Cc: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit c2d06068)
-
The BLT pitch is specified in bytes for linear surfaces and in dwords for tiled surfaces. In both cases the programmable limit is 32,767, so adjust the check to compensate for the effect of tiling. v2: Tweak whitespace for functions (Kenneth) Signed-off-by:
Chris Wilson <chris@chris-wilson.co.uk> Cc: Kristian Høgsberg <krh@bitplanet.net> Cc: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 8da79b83)
-
In the ARB_fragment_program specification, the result.depth output variable is treated as a vec4, where the fragment depth is stored in the .z component, and the other three components are undefined. This is different than GLSL, which uses a scalar value (gl_FragDepth). To make this consistent for driver backends, this patch makes prog_to_nir use a scalar output variable for FRAG_RESULT_DEPTH, moving result.depth.z into the first component. Fixes Glean's fragProg1 "Z-write test" subtest. Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90000 Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit 7b8f20ec)
-
Cc: 10.6 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 6acb61fc)
-
Cc: 10.6 10.5 10.4 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by:
Chad Versace <chad.versace@intel.com> (cherry picked from commit f9f89444)
-
This probably got broken when the samplers were converted to be indexed by shader type. Seen when looking at bug 89819 though I'm not sure if that really was what the bug was about... Cc: "10.5 10.6" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 6e5970ff)
-
I just botched this when writing the original code. From the ARB_vertex_program specification: "The RSQ instruction approximates the reciprocal of the square root of the absolute value of the scalar operand and replicates it to all four components of the result vector." Fixes a Glean vertProg1 subtest: RSQ test 2 (reciprocal square root of negative value) Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90547 Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Francisco Jerez <currojerez@riseup.net> (cherry picked from commit 15a12795)
-
- Jun 03, 2015
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com>
-
Clearing can happen at a time when various state objects are incoherent and not ready for a draw. Some of the validation functions don't handle this well, so only flush the framebuffer state. This has the advantage of also not doing extra work. This works around some crashes that can happen when clearing. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de> (cherry picked from commit aba33925)
-
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89131 Cc: 10.6 10.5 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 25e9ae2b)
-
And core profile only. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Reviewed-by:
Fredrik Höglund <fredrik@kde.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 1ca60de4)
-
Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Suggested-by:
Ilia Mirkin <imirkin@alum.mit.edu> Cc: Ilia Mirkin <imirkin@alum.mit.edu> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit ef4dd0fc)
-
The next patch will add a test for compatibility profile dispatch, and it seems to make more sense to share the lists. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Cc: Ilia Mirkin <imirkin@alum.mit.edu> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 49ab670f) Conflicts: src/mesa/main/tests/dispatch_sanity.cpp
-
GL_ARB_vertex_attrib_64bit is exclusive to core profile, and none of the other functions added by the extension are advertised in other profiles. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Ilia Mirkin <imirkin@alum.mit.edu> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit a6fa74e6)
-
Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Ilia Mirkin <imirkin@alum.mit.edu> Cc: Dylan Baker <baker.dylan.c@gmail.com> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 4e5efa9e)
-
Currently on the functions that are exclusive to core-profile are implemented. The remainder continue to live in the XML. Additional functions can be moved later. The functions for GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect are put in the dispatch table inside the VBO module, so they do not need to be moved over. The diff of src/mesa/main/api_exec.c before and after this patch is as expected. All of the functions listed in apiexec.py moved out of a 'if (_mesa_is_desktop(ctx))' block into a new 'if (ctx->API == API_OPENGL_CORE)' block. v2: Remove stray shebang line in apiexec.py. Suggested by Ilia. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Reviewed-by:
Ilia Mirkin <imirkin@alum.mit.edu> Cc: Dave Airlie <airlied@redhat.com> Cc: Dylan Baker <baker.dylan.c@gmail.com> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit f20899b7) Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> Conflicts: src/mapi/glapi/gen/gl_genexec.py
-
This reverts commit 30dcaaec. Acked-by:
Fredrik Höglund <fredrik@kde.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 5c4aab58)
-
The extension on which this depends will always be enabled in core profile, and the extension bit is about to be removed. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Reviewed-by:
Fredrik Höglund <fredrik@kde.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 832ea234)
-
This reverts commit 7d212765. Acked-by:
Fredrik Höglund <fredrik@kde.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 90e98ea2)
-
This reverts commit 339ed098. Acked-by:
Fredrik Höglund <fredrik@kde.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit cab233f2)
-
This reverts commit 6ad0b7e0. Acked-by:
Fredrik Höglund <fredrik@kde.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 8bcd14fa)
-
This reverts commit cb499407. Acked-by:
Fredrik Höglund <fredrik@kde.org> Cc: "10.6" <mesa-stable@lists.freedesktop.org> (cherry picked from commit f3e8596a)
-