Enable huc on DG2

The huc doens't work on xe driver. I tried to change "i915.enable_guc=2 to xe.enable_guc=2" in cmdline, but it doesn’t work. Is the HUC loaded and enabled on XE? If not, please help to enable it. Thanks.

(Lucas) Re-purposing this issue: it's now enabled on all platforms but DG2

added BUG label

HuC is loaded by default. Xe don't have kernel parameters. You can verify it is running with: sudo more /sys/kernel/debug/dri/0/gt0/uc/huc_info

Thanks for the reply. huc_info: Segmentation fault Found segmentation fault info in huc_info.

Do you have all the firmwares copied to /lib/firmware/xe ?

There's no /lib/firmware/xe folder, I made a new one and copy the files from /lib/firmware/i915 It doesn't work. Are the firmwares for xe the same as for i915, if not, Where I can get the firmwares for xe? Thanks. Effie

what platform are you testing this on? These are the ones that should have it:

$ modinfo -F firmware build64/drivers/gpu/drm/xe/xe.ko | grep -i huc
xe/tgl_huc_7.9.3.bin
xe/dg1_huc_7.9.3.bin

Others need proper support and entry updated in the kernel for loading the firmware.

I works on TGL, get the firmware modinfo as following: root@DUT1305TGLU:/lib# modinfo firmaware modules/6.1.0-xe+/kernel/drivers/gpu/drm/xe/xe.ko | grep -i huc

modinfo: ERROR: Module firmaware not found. firmware: xe/tgl_huc_7.9.3.bin firmware: xe/dg1_huc_7.9.3.bin

I copied firmware from i915 as following:

root@DUT1305TGLU:/lib/firmware/xe# ll total 2204 drwxr-xr-x 2 root root 4096 Mar 8 01:09 ./ drwxr-xr-x 91 root root 20480 Mar 8 01:08 ../ -rw-r--r-- 1 root root 530368 Mar 8 01:09 tgl_huc_7.0.12.bin -rw-r--r-- 1 root root 521408 Mar 8 01:09 tgl_huc_7.0.3.bin -rw-r--r-- 1 root root 580736 Mar 8 01:09 tgl_huc_7.5.0.bin -rw-r--r-- 1 root root 589888 Mar 8 01:09 tgl_huc_7.9.3.bin

As if it doesn't load the firmware successfully.

@Effiey you have a typo. Also the modinfo command is to check the firmware blobs the driver expect on the filesystem. To check if huc is loading, load xe and check dmesg.

@demarchi Do you mean that I missed "-F"? If so, I added it and there's no info displayed. modinfo -F firmaware /lib/modules/6.1.0-xe+/kernel/drivers/gpu/drm/xe/xe.ko | grep -i huc

s/firmaware/firmware/

As if the huc firmware isn't loaded. And we want to know how to load the firmware correctly?

Also, apparently huc isn't implemented yet for DG2? Or is DG2 still completely broken?

I works on TGL not on DG2.

@kode54 / @Effiey see the output of the modinfo command above. Currently it's only implemented for TGL and DG1. DG2 needs a little bit more work due to the GuC deprivilege.

I think ADL-S/ADL-P/RKL may be easier to add. @anushas can you help with these?

@demarchi On it.

removed BUG label

added Improvement label

removed Improvement label

added BUG label

This bug happens on TGL.......

@Effiey you just said above it works on TGL. Please stop changing the labels in this issue.

$ sudo dmesg | grep -i huc
[  258.206922] xe 0000:00:02.0: [drm:xe_huc_auth [xe]] HuC authenticated
$ sudo -i 
root@DUT137TGLU:~# cat /sys/kernel/debug/dri/0/gt0/
HuC firmware: xe/tgl_huc_7.9.3.bin
        status: RUNNING
        version: wanted 7.9, found 7.9
        uCode: 589504 bytes
        RSA: 256 bytes

HuC status: 0x00090001

I said that I do the work on the TGL. Not it works on TGL. I can't see any message with the command: sudo dmesg | grep -i huc`

HuC support for ADL-S landed in a55a6af5