-
- Downloads
drm/xe: Remove i915 header dependency when building without display
If xe is built without support for driving display, it shouldn't need the i915 headers. As a consequence the build system shouldn't be passing the additional CFLAGS to include the i915 directories. However as the display structs were needed in other compilation units, it was not possible to remove, leading to every single file indirectly including the i915 headers via xe_device_types.h. The Makefile had a note about i915 register definitions, but missed the display dependencies. Now that the display substruct from xe_device and the info substruct from xe->info are initialized by display-only files, it's possible to shield the rest of the driver with some additional ifdefs. Ideally the structs should be made opaque and only defined in the display compilation units: this would allow removing the includes from xe_device_types.h even when building with display. However this needs more refactors and cleanups because the i915 files expect the info and display substruct to be available from drm_i915_private that is aliased by xe_device when building xe. So, to avoid future dependencies on the i915 headers, just add a few more ifdefs in the header so a build without display breaks if this is attempted. Signed-off-by:Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by:
Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://lore.kernel.org/r/20230302013411.3262608-8-lucas.demarchi@intel.com
-
mentioned in issue #232 (closed)
-
mentioned in commit 87986755
-
mentioned in commit a8e6bd37
-
mentioned in commit de2b4c52
-
mentioned in commit f14ec693
-
mentioned in commit c52fcf61
-
mentioned in commit 594d77d9
-
mentioned in commit f0216cc7
-
mentioned in commit 53b80e0c
-
mentioned in commit b1b9f982
-
mentioned in commit dc7e6972
-
mentioned in commit e80202ba
-
mentioned in commit 65ba1dcb
-
mentioned in commit 081d3b43
-
mentioned in commit 6ef60a16
-
mentioned in commit 1ac2bf5c
-
mentioned in commit 17d7ab32
-
mentioned in commit 2b5b568f
-
mentioned in commit 714139dc
-
mentioned in commit 3ee9a987
-
mentioned in commit 41dbf834
-
mentioned in commit 0122583b
-
mentioned in commit eb9131d9
-
mentioned in commit 8b31ea4a
-
mentioned in commit 8a6c44e5
-
mentioned in commit Mesa_CI/repos/linux@4c53d387