Skip to content
Snippets Groups Projects
Commit 1f47ed29 authored by Jens Axboe's avatar Jens Axboe
Browse files

block: cleanup and fix batch completion adding conditions

The conditions for whether or not a request is allowed adding to a
completion batch are a bit hard to read, and they also have a few
issues. One is that ioerror may indeed be a random value on passthrough,
and it's being checked unconditionally of whether or not the given
request is a passthrough request or not.

Rewrite the conditions to be separate for easier reading, and only check
ioerror for non-passthrough requests. This fixes an issue with bio
unmapping on passthrough, where it fails getting added to a batch. This
both leads to suboptimal performance, and may trigger a potential
schedule-under-atomic condition for polled passthrough IO.

Fixes: f794f335 ("block: add support for blk_mq_end_request_batch()")
Link: https://lore.kernel.org/r/20575f0a-656e-4bb3-9d82-dec6c7e3a35c@kernel.dk


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 96b531f9
No related branches found
No related tags found
No related merge requests found
Loading
  • CI @project_6562_bot_3b694df01c2c1ffadb3454960c315475

    mentioned in commit e5c2bcc0

    ·

    mentioned in commit e5c2bcc0

    Toggle commit list
  • CI @project_6562_bot_3b694df01c2c1ffadb3454960c315475

    mentioned in commit 9bce6b5f

    ·

    mentioned in commit 9bce6b5f

    Toggle commit list
  • CI @project_6562_bot_3b694df01c2c1ffadb3454960c315475

    mentioned in commit 77213a42

    ·

    mentioned in commit 77213a42

    Toggle commit list
  • CI @project_6562_bot_3b694df01c2c1ffadb3454960c315475

    mentioned in commit 527bde0d

    ·

    mentioned in commit 527bde0d

    Toggle commit list
  • CI @project_6562_bot_3b694df01c2c1ffadb3454960c315475

    mentioned in commit 33e03f19

    ·

    mentioned in commit 33e03f19

    Toggle commit list
  • CI @project_6562_bot_3b694df01c2c1ffadb3454960c315475

    mentioned in commit 7612ae9b

    ·

    mentioned in commit 7612ae9b

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment