Skip to content
Snippets Groups Projects
  • Arnd Bergmann's avatar
    98f3ab18
    ARM: OMAP1: select CONFIG_GENERIC_IRQ_CHIP · 98f3ab18
    Arnd Bergmann authored
    When GENERIC_IRQ_CHIP is disabled, OMAP1 kernels fail to link:
    
    arm-linux-gnueabi-ld: arch/arm/mach-omap1/irq.o: in function `omap1_init_irq':
    irq.c:(.init.text+0x1e8): undefined reference to `irq_alloc_generic_chip'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x228): undefined reference to `irq_setup_generic_chip'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x2a8): undefined reference to `irq_gc_set_wake'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b0): undefined reference to `irq_gc_mask_set_bit'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b4): undefined reference to `irq_gc_mask_clr_bit'
    
    This has apparently been the case for many years, but I never caught it
    in randconfig builds until now, as there are dozens of other drivers
    that also 'select GENERIC_IRQ_CHIP' and statistically there is almost
    always one of them enabled.
    
    Fixes: 55b44774 ("ARM: OMAP1: Switch to use generic irqchip in preparation for sparse IRQ")
    Link: https://lore.kernel.org/r/20250205121151.289535-1-arnd@kernel.org
    
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    98f3ab18
    History
    ARM: OMAP1: select CONFIG_GENERIC_IRQ_CHIP
    Arnd Bergmann authored
    When GENERIC_IRQ_CHIP is disabled, OMAP1 kernels fail to link:
    
    arm-linux-gnueabi-ld: arch/arm/mach-omap1/irq.o: in function `omap1_init_irq':
    irq.c:(.init.text+0x1e8): undefined reference to `irq_alloc_generic_chip'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x228): undefined reference to `irq_setup_generic_chip'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x2a8): undefined reference to `irq_gc_set_wake'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b0): undefined reference to `irq_gc_mask_set_bit'
    arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b4): undefined reference to `irq_gc_mask_clr_bit'
    
    This has apparently been the case for many years, but I never caught it
    in randconfig builds until now, as there are dozens of other drivers
    that also 'select GENERIC_IRQ_CHIP' and statistically there is almost
    always one of them enabled.
    
    Fixes: 55b44774 ("ARM: OMAP1: Switch to use generic irqchip in preparation for sparse IRQ")
    Link: https://lore.kernel.org/r/20250205121151.289535-1-arnd@kernel.org
    
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>