Skip to content

DRM MSM fixes for 6.6

Abhinav Kumar requested to merge abhinavk/msm:msm-fixes-abhinav into msm-fixes

Hi Rob

Here are the list of fixes for v6.6:

  • fix to not reset the PHY everytime we start link training but only do it if link training fails. Without this, the PLL unlocked interrupt fires causing "Unexpected DP AUX IRQ 0x01000000 when not busy" spam in the logs since last 2-3 cycles
  • correct the highest bank bit to match downstream device tree for msm8998
  • skip the video mode wait if the timing engine is not enabled. This was introduced after pre_enable flag for DSI video mode panels where we would end up waiting for the video mode done interrupt even before enabling timing engine causing error spam and long bootup times. Hence its a critical fix
  • check the correct return code of irq_of_parse_and_map() in DSI code
  • avoid overflow issues in the dpu bandwidth calculation . This was exposed for high resolution displays and a critical fix to avoid atomic_check failure
  • minor fix to add new lines in DP print messages.
  • Fix to fail atomic_check() if the resolution exceeds max mdp clk. This leads to underflow otherwise if we try to allow that frame.

One small note, while running checkpatch on 95e681ca ("drm/msm/dpu: change _dpu_plane_calc_bw() to use u64 to avoid overflow"), it complains of below error:

_bw-to-use-u64-to-.patch WARNING: Unknown link reference 'Patchwork:', use 'Link:' or 'Closes:' instead #23 (closed): Patchwork: https://patchwork.freedesktop.org/patch/556288/

We have been using Patchwork tag since many cycles now but somehow with the Reported-by tag, its complaining of this.

I have ignored this error right now but wanted to report it as fyi and in case you have any suggestion to fix this.

I will test these changes the next day or two before marking as ready.

Thanks

Abhinav

Edited by Abhinav Kumar

Merge request reports