Skip to content
Snippets Groups Projects
Commit 8de3e97f authored by Liu Peibao's avatar Liu Peibao Committed by Andi Shyti
Browse files

i2c: designware: do not hold SCL low when I2C_DYNAMIC_TAR_UPDATE is not set


When the Tx FIFO is empty and the last command has no STOP bit
set, the master holds SCL low. If I2C_DYNAMIC_TAR_UPDATE is not
set, BIT(13) MST_ON_HOLD of IC_RAW_INTR_STAT is not enabled,
causing the __i2c_dw_disable() timeout. This is quite similar to
commit 2409205a ("i2c: designware: fix __i2c_dw_disable() in
case master is holding SCL low"). Also check BIT(7)
MST_HOLD_TX_FIFO_EMPTY in IC_STATUS, which is available when
IC_STAT_FOR_CLK_STRETCH is set.

Fixes: 2409205a ("i2c: designware: fix __i2c_dw_disable() in case master is holding SCL low")
Co-developed-by: default avatarXiaowu Ding <xiaowu.ding@jaguarmicro.com>
Signed-off-by: default avatarXiaowu Ding <xiaowu.ding@jaguarmicro.com>
Co-developed-by: default avatarAngus Chen <angus.chen@jaguarmicro.com>
Signed-off-by: default avatarAngus Chen <angus.chen@jaguarmicro.com>
Signed-off-by: default avatarLiu Peibao <loven.liu@jaguarmicro.com>
Acked-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent ab2e5c8f
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment