Skip to content
Snippets Groups Projects
Commit 7a5084b1 authored by Simona Vetter's avatar Simona Vetter
Browse files

dim: handle conflicts when updating the rerere-cache


Ever since we implemented the explicit garbage-collection logic for
the rr-cache/ entries there's been reports by committers that the git
pull in drm-rerere failed. I think I've seen that now enough times to
distill at least 2 patters:

- Race with someone else hitting the same conflict, or at least a
  conflict with the same conflict-sha1. Then you have locally preimage
  (and perhaps other files) which conflict. Because those files are
  numbered it's pretty hard to merge them automatically, so best to
  just throw away the local stuff.

- git gc removed a bunch of rr-cache/ entries. We've never figured out
  how exactly the gc logic for rr-cache entries works, except it seems
  to be atime based and extremely erratic. Again best option is to
  just reset and let dim gc rr-cache/ entries explicitly (and in a
  much more consistent way).

I think the only risk in this patch is if 2 people resolved the exact
same conflict in drm-tip, but then maybe they should start talking
with each another on irc instead of just looking at dim output.
Throwing away the 2nd conflict resolution shouldn't result in much
harm at least.

Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
parent 8bd906b4
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment