-
- Downloads
linux/dim: Fix overflow in dim calculation
While using net_dim, a dim_sample was used without ever initializing the comps value. Added use of DIV_ROUND_DOWN_ULL() to prevent potential overflow, it should not be a problem to save the final result in an int because after the division by epms the value should not be larger than a few thousand. [ 1040.127124] UBSAN: Undefined behaviour in lib/dim/dim.c:78:23 [ 1040.130118] signed integer overflow: [ 1040.131643] 134718714 * 100 cannot be represented in type 'int' Fixes: 398c2b05 ("linux/dim: Add completions count to dim_sample") Signed-off-by:Yamin Friedman <yaminf@mellanox.com> Signed-off-by:
Leon Romanovsky <leonro@mellanox.com> Acked-by:
Saeed Mahameed <saeedm@mellanox.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/net/ethernet/broadcom/bcmsysport.c 1 addition, 1 deletiondrivers/net/ethernet/broadcom/bcmsysport.c
- drivers/net/ethernet/broadcom/bnxt/bnxt.c 1 addition, 1 deletiondrivers/net/ethernet/broadcom/bnxt/bnxt.c
- drivers/net/ethernet/broadcom/genet/bcmgenet.c 1 addition, 1 deletiondrivers/net/ethernet/broadcom/genet/bcmgenet.c
- drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c 2 additions, 2 deletionsdrivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
- lib/dim/dim.c 2 additions, 2 deletionslib/dim/dim.c
Loading
Please register or sign in to comment