igt@perf_pmu@frequency - fail - Failed assertion: (double)(min[0]) <= (1.0 + (tolerance)) * (double)(min_freq) && (double)(min[0]) >= (1.0 - (tolerance)) * (double)(min_freq)

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12074/re-dg2-13/igt@perf_pmu@frequency.html

Starting subtest: frequency
(perf_pmu:1798) CRITICAL: Test assertion failure function test_frequency, file ../tests/i915/perf_pmu.c:1636:
(perf_pmu:1798) CRITICAL: Failed assertion: (double)(min[0]) <= (1.0 + (tolerance)) * (double)(min_freq) && (double)(min[0]) >= (1.0 - (tolerance)) * (double)(min_freq)
(perf_pmu:1798) CRITICAL: 'min[0]' != 'min_freq' (347.914580 not within +5.0%/-5.0% tolerance of 300.000000)
Subtest frequency failed.

added feature: Perf/PMU platform: DG2 labels

The CI Bug Log issue associated to this bug has been updated by .

New filters associated

• DG2 : igt@perf_pmu@frequency - fail - Failed assertion: (double)(min[0]) <= (1.0 + (tolerance)) * (double)(min_freq) && (double)(min[0]) >= (1.0 - (tolerance)) * (double)(min_freq)
  • https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12074/re-dg2-13/igt@perf_pmu@frequency.html
  • https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12114/re-dg2-13/igt@perf_pmu@frequency.html

On CI, last seen this issue on Sept. 18, 2022, 2:40 a.m. Closing this issue as can not reproduce.

closed

The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.

The CI Bug Log issue associated to this bug has been restored.

All the previous filters are now active.

Issue re-occurred on DG2

reopened

I could not repro this issue locally, locally igt@perf_pmu@frequency is always passes on a DG2. In CI the the failure is being seen occasionally on a DG2 system, though even on that system it was not seen for a while resulting in the bug being closed and later reopened.

Also for this local reproduction the freq measured by PMU using a command such as:

sudo ./perf stat -e i915_0000_4d_00.0/requested-frequency/ -I 1000

matches the set freq as long as there are no idle periods (for the effect of idle periods on divergence of PMU and sysfs freq's see #7025 (closed)).

The failure in igt@perf_pmu@frequency in this bug is as follows: the test sets a min == max freq, runs a spinner and then compares the requested freq measured by PMU against the min == max freq set. The test fails when the PMU measured freq if outside a tolerance of the set freq.

I am considering an enhancement to the test which should minimize such sporadic failures. Note that the PMU measured freq is compared against the set freq, not against an "actual" freq, whatever this "actual" freq might be. So my proposal would be to estimate this "actual" freq by sampling the sysfs over a period (say every 5 ms, which is the same as the sampling period used by PMU) and then compare the PMU measured freq against the freq measured by sampling the sysfs (rather than against the freq set).

I am planning to submit a patch based on this approach for this bug.

Submitted a simpler patch for this first:

https://patchwork.freedesktop.org/series/110574/

Rather than sampling the sysfs every 5 ms, the patch samples the sysfs just once after PMU (but when the spinner is still running) to estimate the requested freq.

v2 patch adds extra delays for SLPC frequencies to be set.

mentioned in issue #6786 (closed)

Patch moved as part of: https://patchwork.freedesktop.org/series/111282/

The root cause of this issue as well as #6786 (closed) is traced to the breakage of the i915 freq ABI caused by enabling SLPC efficient freq in 95ccf312a1e4f. This issue needs to be resolved before any fixes for these issues can be merged.

Latest comments about this on the mailing list can be seen here.

On CI, last seen this issue on Feb. 28, 2023, 2:10 a.m. Closing this issue as can not reproduce.

closed

added platform: ADL_P platform: DG1 labels

A CI Bug Log filter associated to this bug has been updated by Gundlakarthik.

Description: DG1 ADL_P DG2 : igt@perf_pmu@frequency - fail - Failed assertion: (double)(min[0]) <= (1.0 + (tolerance)) * (double)(min_freq) && (double)(min[0]) >= (1.0 - (tolerance)) * (double)(min_freq)

Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND machine_tag IS IN ["DG1", "DG2", "ADL-P"] AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@perf_pmu@frequency"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["fail"])) AND stderr ~= 'Failed assertion: \(double\)\(min\[0\]\) <= \(1.0 \+ \(tolerance\)\) \* \(double\)\(min_freq\) && \(double\)\(min\[0\]\) >= \(1.0 - \(tolerance\)\) \* \(double\)\(min_freq\)'

New failures caught by the filter:

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13078/re-adlp-pub5/igt@perf_pmu@frequency.html

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13078/re-adlp-pub3/igt@perf_pmu@frequency.html

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-dg1-18/igt@perf_pmu@frequency.html

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13075/shard-dg1-14/igt@perf_pmu@frequency.html

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13076/shard-dg1-17/igt@perf_pmu@frequency.html

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13077/shard-dg1-12/igt@perf_pmu@frequency.html

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13078/shard-dg1-12/igt@perf_pmu@frequency.html

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13078/re-adlp-pub1/igt@perf_pmu@frequency.html

A CI Bug Log filter associated to this bug has been updated by Gundlakarthik.

Description: RPL_S DG1 ADL_P DG2 : igt@perf_pmu@frequency - fail - Failed assertion: (double)(min[0]) <= (1.0 + (tolerance)) * (double)(min_freq) && (double)(min[0]) >= (1.0 - (tolerance)) * (double)(min_freq)

Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND machine_tag IS IN ["DG1", "DG2", "RPL_S", "ADL-P"] AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@perf_pmu@frequency"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["fail"])) AND stderr ~= 'Failed assertion: \(double\)\(min\[0\]\) <= \(1.0 \+ \(tolerance\)\) \* \(double\)\(min_freq\) && \(double\)\(min\[0\]\) >= \(1.0 - \(tolerance\)\) \* \(double\)\(min_freq\)'

New failures caught by the filter:

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13078/re-rpls-1/igt@perf_pmu@frequency.html