[CI][SHARDS] igt@kms_psr@no_drrs - fail - Failed assertion: drrs_disabled(&data)

Submitted by Martin Peres @mupuf

Assigned to José Roberto de Souza @zehortigoza

Link to original bug (#108341)

Description

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_125/fi-icl-u/igt@kms_psr@no_drrs.html

Starting subtest: no_drrs
(kms_psr:1093) CRITICAL: Test assertion failure function main, file ../tests/kms_psr.c:439:
(kms_psr:1093) CRITICAL: Failed assertion: drrs_disabled(&data)
Subtest no_drrs failed.

added CI feature: display/PSR platform: ICL priority::medium severity::minor + 1 deleted label

José Roberto de Souza @zehortigoza said:

Will be fixed by https://patchwork.freedesktop.org/series/56369/

James Ausmus said:

Did that series end up merging?

Martin Peres @mupuf said:

(In reply to James Ausmus from comment 2)

Did that series end up merging?

It does not seem like it... Anyway, bumping the priority since it happens on shards!

James Ausmus said:

From looking at the kms_psr.c test, the assert that is bailing out is only checking if DRRS is supported by the panel, rather than if DRRS is enabled by the driver. This is incorrect, and the test needs to be fixed.

This is not a user impacting issue, but only an IGT issue

Simon Ser @emersion said:

(Not to be confused with https://bugs.freedesktop.org/show_bug.cgi?id=107383 which is a different failure in the same subtest)

This bug only happens on one machine, shard-iclb1, where it always fails. It's hit weekly or so.

(In reply to James Ausmus from comment 4)

From looking at the kms_psr.c test, the assert that is bailing out is only
checking if DRRS is supported by the panel, rather than if DRRS is
enabled by the driver. This is incorrect, and the test needs to be fixed.

This is not a user impacting issue, but only an IGT issue

Agreed. drrs_disabled needs to be fixed.

CC'ing radhakrishna.sripada@intel.com since they last touched the check in commit 7c79e2ca1f78d.

Vanshidhar Konda said:

Lowering the priority of the bug as it has been identified as a bug in the IGT test and occurs on only ICL platforms. It has no impact to the user.

José Roberto de Souza @zehortigoza said:

(In reply to Vanshidhar Konda from comment 6)

Lowering the priority of the bug as it has been identified as a bug in the
IGT test and occurs on only ICL platforms. It has no impact to the user.

It will happen in any GEN8+ platform with a panel that supports PSR and DRRS.

I have the fix but did not got reviews all the times that I sent it.

assigned to @zehortigoza

A CI Bug Log filter associated to this bug has been updated by Lakshmi Vudum:

Description: ICL: igt@kms_psr@(psr2)?no_drrs - fail - Failed assertion: drrs_disabled(&data)

Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND (machine_name IS IN ["fi-icl-u2", "shard-iclb", "shard-iclb1", "shard-iclb2", "shard-iclb3", "shard-iclb4", "shard-iclb5", "shard-iclb6", "fi-icl-u3", "shard-iclb7", "fi-icl-y", "shard-iclb8", "fi-icl-guc", "fi-icl-dsi", "re-icl-u", "fi-icl-u4", "fi-icl-1065g7", "re-jsl-1", "re-jsl-2", "pig-icl-1065g7", "fi-icl-u"] OR machine_tag IS IN ["JSL", "ICL"]) AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_psr@no_drrs", "igt@kms_psr@psr2_no_drrs"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["fail"])) AND stderr ~= 'Failed assertion: drrs_disabled\(&data\)'

New failures caught by the filter:

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8433/re-jsl-1/igt@kms_psr@no_drrs.html
• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8433/re-jsl-1/igt@kms_psr@psr2_no_drrs.html

A CI Bug Log filter associated to this bug has been updated by Lakshmi Vudum:

Description: ICL JSL: igt@kms_psr@(psr2)?no_drrs - fail - Failed assertion: drrs_disabled(&data)

Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND (machine_name IS IN ["fi-icl-u2", "shard-iclb", "shard-iclb1", "shard-iclb2", "shard-iclb3", "shard-iclb4", "shard-iclb5", "shard-iclb6", "fi-icl-u3", "shard-iclb7", "fi-icl-y", "shard-iclb8", "fi-icl-guc", "fi-icl-dsi", "re-icl-u", "fi-icl-u4", "fi-icl-1065g7", "re-jsl-1", "re-jsl-2", "pig-icl-1065g7", "fi-icl-u"] OR machine_tag IS IN ["JSL", "ICL"]) AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_psr@no_drrs", "igt@kms_psr@psr2_no_drrs"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["fail"])) AND stderr ~= 'Failed assertion: drrs_disabled\(&data\)'

No new failures caught with the new filter

added platform: JSL label

added platform: RKL label

A CI Bug Log filter associated to this bug has been updated by Lakshmi Vudum:

Description: ICL JSL RKL: igt@kms_psr@(psr2)?no_drrs - fail - Failed assertion: drrs_disabled(&data)

Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND (machine_name IS IN ["fi-icl-u2", "shard-iclb", "shard-iclb1", "shard-iclb2", "shard-iclb3", "shard-iclb4", "shard-iclb5", "shard-iclb6", "fi-icl-u3", "shard-iclb7", "fi-icl-y", "shard-iclb8", "fi-icl-guc", "fi-icl-dsi", "re-icl-u", "fi-icl-u4", "fi-icl-1065g7", "re-jsl-1", "re-jsl-2", "pig-icl-1065g7", "re-rkl-1", "re-rkl-cham", "fi-icl-u"] OR machine_tag IS IN ["JSL", "ICL"]) AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_psr@no_drrs", "igt@kms_psr@psr2_no_drrs"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["fail"])) AND stderr ~= 'Failed assertion: drrs_disabled\(&data\)'

New failures caught by the filter:

• https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/re-rkl-1/igt@kms_psr@no_drrs.html

Fix("drm/i915/display: Disable DRRS when needed in fastsets") merged.

closed

The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.