igt@kms_selftest@drm_format_helper@.* - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*, Expected dev is not error, but is: -22
Dmesg
Scroll to first warning
<6> [196.710803] [IGT] kms_selftest: starting dynamic subtest drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888
<3> [196.710902] Driver 'drm-kunit-mock-device' was unable to register with bus_type 'kunit' because the bus was not initialized.
<3> [196.710970] # drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:1458
Expected dev is not error, but is: -22
<6> [196.711172] not ok 2 XRGB8888 as native format
<3> [196.711299] Driver 'drm-kunit-mock-device' was unable to register with bus_type 'kunit' because the bus was not initialized.
<3> [196.711398] # drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:1458
Expected dev is not error, but is: -22
<6> [196.711589] not ok 3 remove duplicates
<3> [196.711681] Driver 'drm-kunit-mock-device' was unable to register with bus_type 'kunit' because the bus was not initialized.
<3> [196.711749] # drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:1458
Expected dev is not error, but is: -22
<6> [196.711888] [IGT] kms_selftest: finished subtest drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888, SUCCESS
<6> [196.711922] not ok 4 convert alpha formats
<3> [196.712020] Driver 'drm-kunit-mock-device' was unable to register with bus_type 'kunit' because the bus was not initialized.
<3> [196.712086] # drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:1458
Expected dev is not error, but is: -22
<6> [196.712265] not ok 5 random formats
<6> [196.712269] # drm_test_fb_build_fourcc_list: pass:0 fail:5 skip:0 total:5
<6> [196.712272] not ok 16 drm_test_fb_build_fourcc_list
<6> [196.712277] KTAP version 1
<6> [196.712279] # Subtest: drm_test_fb_memcpyActivity
added platform: ADL_P label
A CI Bug Log filter associated to this bug has been updated by rveesamx.
Description: ADL-P DG1 DG2 GLK SNB MTL_P RKL TGL: igt@kms_selftest@drm_format_helper@.* - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*, Expected dev is not error, but is: -22
Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND machine_tag IS IN ["DG2", "SNB", "MTL-P", "TGL", "GLK", "DG1", "RKL", "ADL-P"] AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgb888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_build_fourcc_list", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_mono", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_abgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_swab", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xrgb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgba5551"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["dmesg-warn", "dmesg-fail"])) AND dmesg ~= 'drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*\n.*Expected dev is not error, but is: -22'
New failures caught by the filter:
This looks like it's probably my fault: the KUnit device helpers don't unregister the bus properly.
I'll look into this properly tomorrow, but a quick (totally untested) patch might look like this:
Incomplete draft patch
From b7e4a6f4c6aeb9f468c5a6efd507166b053d0aa3 Mon Sep 17 00:00:00 2001 From: David Gow <david@ingeniumdigital.com> Date: Wed, 31 Jan 2024 20:57:29 +0800 Subject: [PATCH] kunit: device: Unregister the kunit_bus on shutdown If KUnit is built as a module, and it's unloaded, the kunit_bus is not unregistered. This causes an error if it's then re-loaded later, as we try to re-register the bus. Unregister the bus on shutdown, if it looks valid. Fixes: d03c720e03bd ("kunit: Add APIs for managing devices") Signed-off-by: David Gow <davidgow@google.com> --- lib/kunit/device-impl.h | 2 ++ lib/kunit/device.c | 10 ++++++++++ lib/kunit/test.c | 3 +++ 3 files changed, 15 insertions(+) diff --git a/lib/kunit/device-impl.h b/lib/kunit/device-impl.h index 54bd55836405..5fcd48ff0f36 100644 --- a/lib/kunit/device-impl.h +++ b/lib/kunit/device-impl.h @@ -13,5 +13,7 @@ // For internal use only -- registers the kunit_bus. int kunit_bus_init(void); +// For internal use only -- unregisters the kunit_bus. +void kunit_bus_shutdown(void); #endif //_KUNIT_DEVICE_IMPL_H diff --git a/lib/kunit/device.c b/lib/kunit/device.c index 074c6dd2e36a..dc822dded5b0 100644 --- a/lib/kunit/device.c +++ b/lib/kunit/device.c @@ -54,6 +54,16 @@ int kunit_bus_init(void) return error; } +/* Unregister the 'kunit_bus' in case the KUnit module is unloaded. */ +void kunit_bus_shutdown(void) +{ + /* Make sure the bus exists before we we unregister it. */ + if (IS_ERR(kunit_bus_device)) + return; + + bus_unregister(&kunit_bus_type); +} + /* Release a 'fake' KUnit device. */ static void kunit_device_release(struct device *d) { diff --git a/lib/kunit/test.c b/lib/kunit/test.c index 31a5a992e646..1d1475578515 100644 --- a/lib/kunit/test.c +++ b/lib/kunit/test.c @@ -928,6 +928,9 @@ static void __exit kunit_exit(void) #ifdef CONFIG_MODULES unregister_module_notifier(&kunit_mod_nb); #endif + + kunit_bus_shutdown(); + kunit_debugfs_cleanup(); } module_exit(kunit_exit); -- 2.43.0EDIT: The patch above doesn't completely fix the issue. See the one in the comment below.
Edited by David Gow
please let know if #10136 (closed) is related to this #10143 (closed)
-
I've sent what I think is a proper fix for this out: https://lore.kernel.org/linux-kselftest/20240201060437.861155-2-davidgow@google.com/T/#u
Let me know if that doesn't fix it.
I'm not sure about #10136 (closed), but a look at the dmesg output does suggest that maybe it's related, so it's worth a try.
-
A CI Bug Log filter associated to this bug has been updated by Vinay.
Description: ADL-P DG1 DG2 GLK SNB MTL_P RKL TGL KBL: igt@kms_selftest@drm_format_helper@.* - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*, Expected dev is not error, but is: -22
Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND machine_tag IS IN ["DG2", "SNB", "MTL-P", "TGL", "KBL", "GLK", "DG1", "RKL", "ADL-P"] AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgb888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_build_fourcc_list", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_mono", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_abgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_swab", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xrgb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgba5551"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["dmesg-warn", "dmesg-fail"])) AND dmesg ~= 'drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*\n.*Expected dev is not error, but is: -22'
New failures caught by the filter:
- https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1490/fi-kbl-7567u/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset.html
- https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1492/fi-kbl-7567u/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset.html
added platform: KBL label
-
A CI Bug Log filter associated to this bug has been updated by Vinay.
Description: ADL-P DG1 DG2 GLK SNBll MTL_P RKL TGL KBLachines: igt@kms_selftest@drm_format_helper@.* - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*, Expected dev is not error, but is: -22
Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND machine_tag IS IN ["DG2", "SNB", "MTL-P", "BSW", "SKL", "TGL", "KBL", "GARLK-S", "DG1", "GLK", "RKL", "ADL-P"] AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgb888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_build_fourcc_list", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_mono", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_abgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_swab", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xrgb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgba5551"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["dmesg-warn", "dmesg-fail"])) AND dmesg ~= 'drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*\n.*Expected dev is not error, but is: -22'
New failures caught by the filter:
- https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1487/fi-bsw-nick/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_mono.html
- https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1490/fi-skl-guc/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb8888.html
- https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1494/fi-skl-6600u/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset.html
added platform: ALL label
mentioned in issue #10242 (closed)
-
A CI Bug Log filter associated to this bug has been updated by Vinay.
Description: All Machines: igt@kms_selftest@drm_format_helper@.* - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*, Expected dev is not error, but is: -22
Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND machine_tag IS IN ["DG2", "ADL_N-HW", "SNB", "MTL-P", "BSW", "SKL", "TGL", "KBL", "ARL-S", "DG1", "GLK", "RKL", "ADL-P"] AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgb888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_build_fourcc_list", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_mono", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_abgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_swab", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xrgb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgba5551"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["dmesg-warn", "dmesg-fail"])) AND dmesg ~= 'drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*\n.*Expected dev is not error, but is: -22'
New failures caught by the filter:
-
A CI Bug Log filter associated to this bug has been updated by Vinay.
Description: All Machines: igt@kms_selftest@drm_format_helper@.* - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*, Expected dev is not error, but is: -22
Equivalent query: runconfig_tag IS IN ["DRM-TIP"] AND machine_tag IS IN ["DG2", "ADL_N-HW", "SNB", "IVB", "MTL-P", "BSW", "SKL", "TGL", "KBL", "ARL-S", "DG1", "GLK", "RKL", "ADL-P"] AND ((testsuite_name = "IGT" AND test_name IS IN ["igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgb888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_build_fourcc_list", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_mono", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_abgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_swab", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_argb8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xrgb2101010", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888", "igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_rgba5551"])) AND ((testsuite_name = "IGT" AND status_name IS IN ["dmesg-warn", "dmesg-fail"])) AND dmesg ~= 'drm_test_fb_build_fourcc_list: ASSERTION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:.*\n.*Expected dev is not error, but is: -22'
New failures caught by the filter:
-
The CI Bug Log issue associated to this bug has been updated by Ewelina Musial.
New filters associated
- DG1 MTL-P: igt@kms_selftest@drm_format_helper - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list.* [drm_format_helper_test]
- https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14232/shard-mtlp-5/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset.html
- https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14234/re-mtlp-3/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888.html
- https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14235/shard-mtlp-3/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_swab.html
- https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14234/re-mtlp-2/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_swab.html
- https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7704/shard-dg1-17/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_xbgr8888.html
- https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14228/re-mtlp-2/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_clip_offset.html
- https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14229/shard-mtlp-2/igt@kms_selftest@drm_format_helper@drm_format_helper_test-drm_test_fb_xrgb8888_to_abgr8888.html
- DG1 MTL-P: igt@kms_selftest@drm_format_helper - dmesg-fail/dmesg-warn - drm_test_fb_build_fourcc_list.* [drm_format_helper_test]
-
Closing this issue (#10143 (closed)) as was not seen for more than 21 days