adl: can't output 4k@60hz with tbt4 dock

Platform:
CPU: ADL-ES
GPU: ADL-DVT1

Description:
SUT attach TBT4 dock, plug in two 4K monitor, the monitor resolution can't reach 4K 60Hz

Reproduce Steps:

1. Connect two 4K external monitor to TBT4 dock
2. the monitor resolution can't reach 4K 60Hz

Result:
SUT attach TBT4 dock, plug in two 4K monitor, the monitor resolution can't reach 4K 60Hz

two_4k_ok.log

changed the description

added Community feature: display/Other feature: display/USB-C platform: ADL_S labels

Have you tried with latest drm-tip? See: https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs. @ideak further thoughts?

I suppose the log was taken with the (equivalent of) 0001-drm-i915-adls-Fix-maximum-DP-source-rate.patch fixing the issue?

@ideak you're right, christoph provide the patch you mentioned and i verified it.

So this already fixed or still some actions needed?

@ideak Did you upstream it to the mainline kernel/drmtip? or could you share the patchwork url?

I cannot see such change at https://patchwork.freedesktop.org/project/intel-gfx/series/?ordering=-last_updated (use submitter Imre) so might not be then and need to be sent and reviewed. But let @ideak to comment.

We'll need to pick up https://lore.kernel.org/intel-gfx/20211026104342.198300-2-ankit.k.nautiyal@intel.com/ before doing that I still need to check the spec against all the other platforms.

@ideak Thanks for the review comments on the above patch. I have rebased the above patch, split the patch into 2 (https://patchwork.freedesktop.org/series/96293/)

The fix is pushed to drm-tip:

commit 3fd6afb623ba0f908af4f81794ccdff4dd5e671e
Author: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Date:   Wed Mar 23 15:13:07 2022 +0530

    drm/i915/intel_combo_phy: Print I/O voltage info

closed

mentioned in commit lyudess/linux@73867c87

The fix

commit 73867c8709b569cdd7fda67f01dfe02c8d055521
Author: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Date:   Tue Mar 15 13:32:46 2022 +0530

    drm/i915/display: Remove check for low voltage sku for max dp source rate
    
    The low voltage sku check can be ignored as OEMs need to consider that
    when designing the board and then put any limits in VBT.
    
    Same is now changed in Bspec pages.
    
    Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5272
    
    Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
    Reviewed-by: Imre Deak <imre.deak@intel.com>
    Signed-off-by: Imre Deak <imre.deak@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220315080247.1161844-2-ankit.k.nautiyal@i
ntel.com

has caused #6205 (closed).

added priority::high severity::major labels

removed priority::high label

removed severity::major label

mentioned in issue #6205 (closed)

Due to the regression #6205 (closed) I've pushed the revert d5929835080a ("drm/i915/display: Re-add check for low voltage sku for max dp source rate") to drm-intel-next.

reopened

added priority::high severity::normal labels

The one thing I noticed in the log was some register mismatch in the combo PHY initialization. But it looks like neither the GOP or i915 program that exactly as the spec says (though the i915 value looks technically more in line with the spec).

@koba since the fix is reverted, is it possible to check with the attached patch: 0001-drm-i915-dp-Check-for-Low-voltage-IO-only-for-eDP.patch

sorry, i don't have machine to test.

mentioned in commit nouveau@c7b28f52