John Harrison authored 3 years ago and Ashutosh Dixit committed 3 years ago

Although the hangman test was ensuring that *some* reset functionality
was enabled, it did not differentiate what kind. The infrastructure
required to choose between per engine reset or full GT reset was
recently added. So update this test to use it as well.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

John Harrison authored 3 years ago and Ashutosh Dixit committed 3 years ago

The capture test was still using old style ring_id and ring_name
(derived from the engine structure at the higher level). Update it to
just take the engine structure directly.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

John Harrison authored 3 years ago and Ashutosh Dixit committed 3 years ago

The above function was checking for valid rings via the old interface.
The new scheme is to check for engines on contexts as there are now
more engines than could be supported.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

John Harrison authored 3 years ago and Ashutosh Dixit committed 3 years ago

Added descriptions of the various sub-tests and the test as a whole.

v2: Added missing linefeed (spotted by Petri)

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Jouni Högander authored 3 years ago and Petri Latvala committed 3 years ago

Igt_fixture is in a loop for different operations. This is causing
display_fini being called at the end of each iteration and
triggering SIGSEGV. Fix this by removing igt_fixture out from
the loop.

Fixes: 6be8feeb ("tests/kms_psr2_su: add biplanar selective update tests")
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

Mun Gwan-gyeong authored 3 years ago and Ashutosh Dixit committed 3 years ago

DRM_IOCTL_I915_GEM_SET_DOMAIN ioctl is not supported on discrete platforms.
Skip sd-probe test for discrete platforms.

https://patchwork.freedesktop.org/patch/msgid/20210715101536.2606307-5-matthew.auld@intel.com



v2: add a newline at the end of the skip string and fix the skip string. (Petri)
v3: update the commit message. (Petri)

Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

This test takes up to few hundred of milliseconds and exercises
detecting of safe starting offset and alignment to use on discrete
where memory regions constraints could differ on different gens.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Acked-by: Petri Latvala <petri.latvala@intel.com>

Exercise start offset and alignment detection when we start mixing
system and local memory.

v2: support integrated and check smem <-> smem alignment
v3: iterate over engines to verify safe start is correct everywhere
v4: rename to safe-alignment (Ashutosh)

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

With era of new gens we're enforced to use no-reloc (softpin). This
brings few problems like vm range limitations which were well solved
by the kernel. This can be handled also in userspace code by adding
gen related conditionals or by trying to detect the constraints.

Lets try to do this dynamically and detect safe start offset and
alignment for each memory region we got. This should be universal solution
regardless hw limitations and bugs. As such detection is not lightweight
technique add also some caching structures to handle consequtive calls
about same data.

v2: unify cache
v3: move allocation of cache entry out of mutex
v4: remove assert on allocation newentry, just skip adding to cache
v5: fix function documentation (Ashutosh)
v6: remove unnecessary buffers count initialization (Ashutosh)
    add 48b flag for pinning object

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Tvrtko Ursulin authored 3 years ago and Ashutosh Dixit committed 3 years ago

Commit d7a74b95 ("tests/i915/perf_pmu: Convert to intel_ctx_t (v3)")
broke the test when it is run in its entirety.

Correct context id needs to be used with igt_allow_hang to avoid context
ban preventing the test to run to completion.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: d7a74b95 ("tests/i915/perf_pmu: Convert to intel_ctx_t (v3)")
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Matthew Auld authored 3 years ago and Ashutosh Dixit committed 3 years ago

We need to use the FIXED mapping type on discrete platforms.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

mastan katragadda authored 3 years ago and Ashutosh Dixit committed 3 years ago

Media samplers are not present on some of Gen11 platforms adding
skip on EHL and JSL as per Bspec.

Bspec:29151

Changes since V1 :
        Moved this skip check to igt_get_media_vme_func.[Tony Ye]

CC: Tony Ye <tony.ye@intel.com>
Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
Reviewed-by: Tony Ye <tony.ye@intel.com>

ananya0109 authored 3 years ago and Swati2 Sharma committed 3 years ago

P010 pixel format is newly added to the already existing
list of pixel formats(RGB565,XRGB8888,NV12).

Signed-off-by: Ananya Sharma <ananya.sharma@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

saigowth authored 3 years ago and Zbigniew Kempczyński committed 3 years ago

Add support for local memory region (Device memory)

Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

Tejas Upadhyay authored 3 years ago and Ashutosh Dixit committed 3 years ago

RPLS and ADLS use the same OA metrics. Add RPLS support for OA tests.

Resolves: https://gitlab.freedesktop.org/drm/intel/-/issues/4808


Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Instead of iterating through all the delta, break the execution
when we found a match. This will optimize the time required to
execute ctm-0-* tests.

Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>

Create reference crc with same modifier as is used for testing. This
will reduce non test related anomalies.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

In this patch, added upscaling tests 960x540->1920x1080.
Existing downscaled tests reused for upscaling scenarios.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

This commit adds a DP DSC test that checks:

* Forces DSC on/off and ensures it is reset properly
* Check DSC slice height property
* Verify various DSC slice dimensions
* Tests various combinations of link_rate + lane_count and logs if DSC
  enabled/disabled Tests different bpc settings and logs if DSC is
  enabled/disabled

Change since V3:
 - Drop useless test
Change since V2:
 - Remove IGT_CRTC_DSC_SLICE_HEIGHT crtc property from this commit
Change since V1:
 - Rebase

Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Nicholas Choi <Nicholas.Choi@amd.com>
Cc: Mark Yacoub <markyacoub@chromium.org>
Cc: Hayden Goodfellow <hayden.goodfellow@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Roman Li <roman.li@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
Signed-off-by: Eryk Brol <eryk.brol@amd.com>

Adding Alder lake N platform definitions

Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

This synchronizes with kernel commit

7e28d0b26759 ("drm/i915/adl-n: Enable ADL-N platform")
to bring in ADL-N PCI IDs.

Acked-by: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

saigowth authored 3 years ago and Zbigniew Kempczyński committed 3 years ago

Add support for local memory region (Device memory)

Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

Tejas Upadhyay authored 3 years ago and Petri Latvala committed 3 years ago

Adding Raptor lake platform definitions

Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Signed-off-by: Raviteja Goud Talla <ravitejax.goud.talla@intel.com>

This synchronizes with kernel commit

52407c220c44 ("drm/i915/rpl-s: Add PCI IDS for Raptor Lake S")

to bring in RPL-S PCI IDs.

Acked-by: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

Even though the best practices for dynamic subtests is to not execute
the dynamic subtest at all instead of skipping, there are a couple of
tests that to the opposite, without an easy way to construct them
along best practices. Accomodate this with fixing the handling of
skipping dynamic subtests so that the result of the containing subtest
becomes a skip also if all dynamic subtests skip, not just when there
are no dynamic subtests.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arek@hiler.eu>
Cc: Jari Tahvanainen <jari.tahvanainen@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

clear_yuv_buffer() checks the size of the plane_size[] to
make sure its greater than the number of planes to avoid
overflows.

The plane_size[] is fixed to two currently.

However some of the formats like YV12 indeed have more than
2 planes in the format_desc[] hence this incorrectly failing
this check.

Increase the size of the plane_size[] to match the correct
max number of planes.

changes in v3:
	- use drm_format->num_planes to create the plane_size
	- add assert checks for num of planes before memset

Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Bonding is disabled on GEN12+ platforms, except ones already
supported by the i915 - TGL, RKL, and ADL-S.

Currently few tests are failing for same reason, with this
change they should rightly skip with proper message.

Reference: https://cgit.freedesktop.org/drm-tip/commit/?id=ce7e75c7ef1bf8ea3d947da8c674d2f40fd7d734



Changes since V3 :
	- Initalization of bonding boolean not required - zbigniew
Changes since V2 :
        - Solved checkpatch errors.
Changes since V1 :
        - use function to check bonding capability so that
          we dont skip whole test in case bonding not supported.

Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

As Ashutosh noticed I've handled errors from the kernel too wide
packing it to same error bag and returning system memory region in this
case. That's of course is wrong and can lead to return system memory on
discrete if invalid arguments would be passed to the query.

Return previous behavior of query memory regions handling -ENODEV path
individually. For this error lets assume we got kernel which doesn't
support this query yet so returning system memory region is a reasonable
choice because this region exists for all of i915 gens.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reported-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

For stable kernels we get -ENODEV on integrated where gem_create_ext()
call tries to allocate bo in system memory. Instead of asserting this
case we can fallback to gem_create() as this allocation can be resolved
using legacy call.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

For stable kernels we can currently get -ENODEV on integrated gens
when no CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM is set.

Provide system memory region stub to avoid failing on querying
kernel for memory regions.

v2: use offsetof() instead of manual size calculation

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Deepak Rawat authored 3 years ago and KunalJoshi95 committed 3 years ago

Some simple test cases to use FB_DAMAGE_CLIPS plane property.
Issue a plane update with damage with a clips on different scenarios
and verify the state.

v2: use drm_mode_rect instead of local struct and array instead of malloc.

Signed-off-by: Deepak Rawat <drawat@vmware.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

Jeevan B authored 3 years ago and KunalJoshi95 committed 3 years ago

Change testcase design so that it avoids new subtest for each block position.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Jeevan B authored 3 years ago and KunalJoshi95 committed 3 years ago

rename igt_debug_manual_check and patch the igt function
igt_debug_wait_for_keypress() to assert if "all" is supplied.

v2: calling igt_debug_wait_for_keypress() with "all" will assert.
v3: Change igt_assert to igt_assert_f for adding clear log message.
v4: Rebase only.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

mastan katragadda authored 3 years ago and Tejas Upadhyay committed 3 years ago

The reason for this is that it doesn't work with the dma-resv-object locking introduced
recently in the code,and it's not going to be fixed anytime soon.

drm/i915: Perform execbuffer object locking as a separate step
To help avoid evicting already resident buffers from the batch we're
processing, perform locking as a separate step.

Link:https://cgit.freedesktop.org/drm-tip/commit/?id=5cd57f676bb946a00275408f0dd0d75dbc466d25



Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

mastan katragadda authored 3 years ago and Tejas Upadhyay committed 3 years ago

This test makes assumptions about the backend scheduling algorithm that
a real world UMD would never assume. This test is not testing a UMD-KMD
contract, rather a specific backend.It is an invalid test case thus we
are skipping.

Changes Since v1:
             -Updated commit message

Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

[Why]
flip_vs_cursor_crc and flip_vs_cursor_busy_crc use CRC in debugfs which is
not supported by some drivers.

[How]
igt_require_pipe_crc in igt_fixture before the subtests start.

Test: igt@kms_cursor_legacy@flip-vs-cursor{-busy}-crc-{atomic,legacy} on
ChromeOS Jacuzzi (MTK)

Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Tests that reads and/or writes to kernel managed buffers which should be
inaccessible to userspace controlled cmdstream, are indeed inaccessible.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Split the readN()/writeN() helpers out into an igt_io module, so they
can be re-used by tests.

Signed-off-by: Rob Clark <robdclark@chromium.org>

[Why]
Mediatek devices have a HW issue with sending their vblank IRQ at the same time interval
everytime. The drift can be below or above the expected frame time, causing the
timestamp to drift with a relatively larger standard deviation over a large sample.

[How]
Filter out the flags TEST_CHECK_TS and TEST_VBLANK_EXPIRED_SEQ from the
tests flags, and restrict sequence and ts checks.

Tested on Jacuzzi (MT8183)

Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>