Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D drm-hwcomposer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 12
    • Issues 12
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • drm-hwcomposer
  • drm-hwcomposer
  • Merge requests
  • !168

drm_hwcomposer: Assume premultiplied alpha for CLIENT layer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Stultz requested to merge john.stultz/drm-hwcomposer:premult-blending into main Dec 10, 2021
  • Overview 9
  • Commits 1
  • Pipelines 3
  • Changes 1

On db845c, we have seen an odd behavior with modal dialogs in AOSP, where the background which is normally darkened, was rendering as black, though it would occasionally flicker to the right thing. This cropped up after alpha support on planes landed in 5.15, so we assumed it was an edge case issue with the dpu1 driver.

But while working on a separate issue seen on x86 hardware: #46 (closed)

Roman noticed drm_hwcomposer always sets the blending type to NONE for the client layer. Which had gone un-noticed becase he didn't have any devices that exposed the NONE type.

Thus Roman implemented this patch, which sets up the client blend type to PREMULTIPLIED.

While it did not resolve the x86 issue above, it does resolve the incorrect rendering seen on db845c with alpha support enabled.

Signed-off-by: Roman Stratiienko roman.o.stratiienko@globallogic.com Signed-off-by: John Stultz john.stultz@linaro.org Change-Id: I95601c680ca1af0dc9d3b3f102f79f77af081b75

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: premult-blending