Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D drm-hwcomposer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 12
    • Issues 12
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • drm-hwcomposer
  • drm-hwcomposer
  • Merge requests
  • !159

[RFC] drm_hwcomposer: Fix for setting one too many prime_fds

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed John Stultz requested to merge john.stultz/drm-hwcomposer:biplane-fix into main Oct 20, 2021
  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 1

When trying to work with NV12 buffers, I'm seeing lots of the following noise:

10-20 20:39:40.855 474 474 E hwc-drm-two: Failed to import layer, ret=-22 10-20 20:39:40.888 474 474 E hwc-platform-drm-generic: could not create drm fb -22 10-20 20:39:40.888 474 474 E hwc-platform-drm-generic: Failed to rm fb 10-20 20:39:40.888 474 474 E hwc-drm-utils: Failed to import buffer

Digging back it seems we're setting three fds for 2 plane formats.

This patch changes it so we only set two, which stops the import errors.

(NOTE: I'm still not seeing the NV12 buffers rendered properly, but I'm not yet sure where that issue is stemming from).

Signed-off-by: John Stultz john.stultz@linaro.org Change-Id: Id5493e37f17053740ca6b643fd838a2d11507462

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: biplane-fix