Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D drm-hwcomposer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • drm-hwcomposer
  • drm-hwcomposer
  • Issues
  • #14
Closed
Open
Issue created Jun 03, 2018 by maurossi@issor.oruam

DrmResources::Init set display logic is flawed

If you follow the code @line 160: // First look for primary amongst internal connectors

  // First look for primary amongst internal connectors
  for (auto &conn : connectors_) {
    if (conn->internal() && !found_primary) {
      conn->set_display(0);
      found_primary = true;
    } else {
      conn->set_display(display_num);
      ++display_num;
    }
  }

  // Then look for primary amongst external connectors
  for (auto &conn : connectors_) {
    if (conn->external() && !found_primary) {
      conn->set_display(0);
      found_primary = true;
    }
  }

if any internal connector is present display 0 is set and considered as primary. With discrete GPUs, having multiple connectors, that is not correct.

Hack [1] even if a ugly hack and does not consider multiple displays, avoids the current defect in assigning display 0 and found_primary, because by changing the current logic the Android GUI can boot with nouveau,

with the current implementation Android cannot boot on any discrete GPU.

This ticket purpose is to have a placeholder to correct the defect in some way.

Mauro Rossi

[1] https://github.com/maurossi/drm_hwcomposer/commit/a3fc27612d98bba1a3f3d959d557af2d49ad5889

Edited Jun 08, 2018 by maurossi
Assignee
Assign to
Time tracking