Skip to content
Snippets Groups Projects
  1. Jul 07, 2016
  2. Jun 15, 2016
  3. Jun 01, 2016
  4. May 31, 2016
  5. May 28, 2016
    • Ting-Yuan Huang's avatar
      plugin-manager: protect mm_plugin_{major,minor}_version · 969189d4
      Ting-Yuan Huang authored and Aleksander Morgado's avatar Aleksander Morgado committed
      This patch makes declarations bind to definitions within the same module
      to prevent the potential ambiguity if referenced directly.
      
      AddressSanitizer think they violated one definition rule, although
      those symbols are accessed by address through their modules and do
      not depend on the order of the libararies loaded.
      969189d4
  6. May 27, 2016
  7. May 24, 2016
    • Dan Williams's avatar
      broadband-bearer-icera: deactivate context before authentication · 830b6ebc
      Dan Williams authored
      If the modem thinks a PDP context is already active it'll return
      583 errors from IPDPCFG and IPDPACT until the context is
      deactivated.  Deactivation was previously done after authentication,
      but needs to be done before any part of the connect process to
      ensure the PDP context is inactive.
      
      The previous approach worked only if the context was being
      deactivated already (which can take a bit of time) because it would
      be deactivated after a few seconds and the connect could continue.
      This approach works for more cases (like a MM crash and restart
      while the modem is connected).
      830b6ebc
  8. May 10, 2016
    • Lubomir Rintel's avatar
      mbm: clean up the context on activate_ready · e27f4a62
      Lubomir Rintel authored and Dan Williams's avatar Dan Williams committed
      Otherwise the dangling pointer to the context that's being deallocated causes a
      crash on spontaneous E2NAP receipt:
      
        ModemManager[1567]: <info>  [1462468083.031326] [mm-iface-modem.c:1431] __iface_modem_update_state_internal(): Modem /org/freedesktop/ModemManager1/Modem/0: state changed (connecting -> registered)
        ModemManager[1567]: <debug> [1462468083.053745] [mm-port-serial-at.c:459] debug_log(): (ttyACM0): <-- '<CR><LF>*E2NAP: 0,36<CR><LF>'
        ModemManager[1567]: <debug> [1462468083.053857] [mbm/mm-broadband-modem-mbm.c:824] e2nap_received(): disconnected
      
        (ModemManager:1567): GLib-GIO-CRITICAL **: g_simple_async_result_set_error: assertion 'G_IS_SIMPLE_ASYNC_RESULT (simple)' failed
      
        Program received signal SIGTRAP, Trace/breakpoint trap.
        g_logv (log_domain=0x7ffff7086798 "GLib-GIO", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffcda0) at gmessages.c:1046
        1046              g_private_set (&g_log_depth, GUINT_TO_POINTER (depth));
        Missing separate debuginfos, use: debuginfo-install libmbim-1.12.4-2.el7.centos.x86_64 libqmi-1.14.2-1.el7.centos.x86_64
        (gdb) bt
        #0  0x00007ffff6a508c3 in g_logv (log_domain=0x7ffff7086798 "GLib-GIO", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffcda0) at gmessages.c:1046
        #1  0x00007ffff6a50a3f in g_log (log_domain=log_domain@entry=0x7ffff7086798 "GLib-GIO", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7ffff6abe73d "%s: assertion '%s' failed") at gmessages.c:1079
        #2  0x00007ffff6a50a79 in g_return_if_fail_warning (log_domain=log_domain@entry=0x7ffff7086798 "GLib-GIO", pretty_function=pretty_function@entry=0x7ffff7092ce0 <__FUNCTION__.13394> "g_simple_async_result_set_error", expression=expression@entry=0x7ffff7092a40 "G_IS_SIMPLE_ASYNC_RESULT (simple)") at gmessages.c:1088
        #3  0x00007ffff6ff9d3d in g_simple_async_result_set_error (simple=0x7fffe8006e40, domain=297, code=0, format=0x7ffff175b53f "Call setup failed") at gsimpleasyncresult.c:719
        #4  0x00007ffff17569ea in report_connection_status (bearer=0x7fffe4008a40 [MMBroadbandBearerMbm], status=MM_BEARER_CONNECTION_STATUS_DISCONNECTED) at mbm/mm-broadband-bearer-mbm.c:174
        #5  0x000055555559c9f1 in mm_base_bearer_report_connection_status (self=0x7fffe4008a40 [MMBroadbandBearerMbm], status=MM_BEARER_CONNECTION_STATUS_DISCONNECTED) at mm-base-bearer.c:1118
        #6  0x00007ffff17548ed in bearer_list_report_status_foreach (bearer=0x7fffe4008a40 [MMBroadbandBearerMbm], ctx=0x7fffffffd060) at mbm/mm-broadband-modem-mbm.c:805
        #7  0x00007ffff6a45f18 in g_list_foreach (list=<optimized out>, func=0x7ffff17548c9 <bearer_list_report_status_foreach>, user_data=0x7fffffffd060) at glist.c:994
        #8  0x00005555555a224b in mm_bearer_list_foreach (self=0x5555558e0680 [MMBearerList], func=0x7ffff17548c9 <bearer_list_report_status_foreach>, user_data=0x7fffffffd060) at mm-bearer-list.c:146
        #9  0x00007ffff1754a3d in e2nap_received (port=0x5555558e24c0 [MMPortSerialAt], info=0x555555935730, self=0x555555900330 [MMBroadbandModemMbm]) at mbm/mm-broadband-modem-mbm.c:850
        #10 0x000055555563d9fd in parse_unsolicited (port=0x5555558e24c0 [MMPortSerialAt], response=0x7fffe80054f0) at mm-port-serial-at.c:280
        #11 0x0000555555639915 in parse_response_buffer (self=0x5555558e24c0 [MMPortSerialAt]) at mm-port-serial.c:889
        #12 0x0000555555639f0b in common_input_available (self=0x5555558e24c0 [MMPortSerialAt], condition=G_IO_IN) at mm-port-serial.c:1019
        #13 0x0000555555639fc7 in iochannel_input_available (iochannel=0x555555926df0, condition=G_IO_IN, data=0x5555558e24c0) at mm-port-serial.c:1042
        #14 0x00007ffff6a4979a in g_main_context_dispatch (context=0x5555558a4a00) at gmain.c:3109
        #15 0x00007ffff6a4979a in g_main_context_dispatch (context=context@entry=0x5555558a4a00) at gmain.c:3708
        #16 0x00007ffff6a49ae8 in g_main_context_iterate (context=0x5555558a4a00, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3779
        #17 0x00007ffff6a49dba in g_main_loop_run (loop=0x5555558acf10) at gmain.c:3973
        #18 0x000055555558d068 in main (argc=2, argv=0x7fffffffdc38) at main.c:181
        (gdb)
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1333293
      https://bugs.freedesktop.org/show_bug.cgi?id=95303
      e27f4a62
  9. May 04, 2016
  10. May 03, 2016
    • Daniele Palmas's avatar
      build: modified Telit and Dell sections · 1af8304a
      Daniele Palmas authored and Dan Williams's avatar Dan Williams committed
      This patch adds section for building Telit common code and modifies
      Dell section for using Telit library
      1af8304a
    • Daniele Palmas's avatar
      dell: add udev rules for 413c/81ba · ed97ebf6
      Daniele Palmas authored and Dan Williams's avatar Dan Williams committed
      udev rules for Dell-branded 413c/81ba Telit modem are used for dynamic
      port configuration in Telit plugin custom init
      ed97ebf6
    • Daniele Palmas's avatar
      dell: add Telit manufacturer · 4403bb77
      Daniele Palmas authored and Dan Williams's avatar Dan Williams committed
      Dell-branded AT based Telit modems should use Telit plugin functions
      4403bb77
    • Daniele Palmas's avatar
      telit: code refactoring · 850318fd
      Daniele Palmas authored and Dan Williams's avatar Dan Williams committed
      This patch moves init and port grabbing functions to a separate file
      to allow functions call from Dell plugin
      850318fd
    • Dan Williams's avatar
      bearer-mbim: fine-tune bearer IP method reporting · f5a061ef
      Dan Williams authored
      v4: modems/providers may not return DNS servers and not all modems
      support DHCP, so lack of DNS servers should not indicate a bearer
      IP method of "DHCP".  IP config daemon/scripts already have to handle
      missing DNS anyway.
      
      v6: IPv6 requires SLAAC or DHCPv6 as part of the specification, so for
      now we assume modems will support it.  Provide all the info the modem
      sent, but if there is any missing information use an IP method of
      "DHCP" to indicate that info should be obtained via SLAAC/DHCPv6.  Only
      use an IP method of "STATIC" when all basic properties are given by
      the modem.
      f5a061ef
  11. Apr 19, 2016
  12. Apr 18, 2016
  13. Apr 15, 2016
  14. Apr 13, 2016
  15. Apr 08, 2016
    • Aleksander Morgado's avatar
      port-probe: make sure stored task pointer is set to NULL before completing · 276e28fe
      Aleksander Morgado authored
      When we were completing tasks in idle, the logic was like this:
      
       * Schedule task completion in idle
       * self->priv->task = NULL
       * (idle) Task completion callback called
      
      This meant that the self->priv->task was always set to NULL before the
      completion callback was called, which is what we wanted as a new task may be
      scheduled in the callback itself.
      
      Now, without completing in idle, we were wrongly doing:
      
       * Task completion callback called
       * self->priv->task = NULL
      
      This commit fixes the logic by making sure self->priv->task = NULL before any
      task completion.
      276e28fe
  16. Apr 06, 2016
    • Carlo Lobrano's avatar
      dell: fixed cgmi_retries in dell_custom_init · 8a386218
      Carlo Lobrano authored and Aleksander Morgado's avatar Aleksander Morgado committed
      Initialized "cgmi_retries" variable from CustomInitContext with the
      same value as the other retries, moreover the context is now allocated
      with g_slice_new0.
      
      Before this changes, when cgmi_retries assumed big values during the
      probing of no AT-capable ports, the command AT+CGMI (mm-plugin-dell.c:custom_init_step)
      was sent a semi-infinite number of times, blocking the plugin's initialization.
      8a386218
  17. Apr 03, 2016
  18. Mar 27, 2016
  19. Mar 26, 2016
  20. Mar 25, 2016
    • Aleksander Morgado's avatar
    • Brian Norris's avatar
      libmm-glib: fix enum conversion warning/error · 34961f20
      Brian Norris authored and Aleksander Morgado's avatar Aleksander Morgado committed
      mm-modem-oma.c:400:51: error: implicit conversion from enumeration type 'MMOmaSessionType' to different enumeration type 'MMOmaFeature'
            [-Werror,-Wenum-conversion]
          g_return_val_if_fail (MM_IS_MODEM_OMA (self), MM_OMA_SESSION_TYPE_UNKNOWN);
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /usr/include/glib-2.0/glib/gmessages.h:382:11: note: expanded from macro 'g_return_val_if_fail'
               return (val);                                                  \
               ~~~~~~  ^~~
      
      This should be MMOmaFeature, not MMOmaSessionType. The end result is the same,
      as both are 0.
      34961f20
Loading