Skip to content
Snippets Groups Projects
  1. Feb 10, 2015
  2. Jan 29, 2015
  3. Jan 26, 2015
  4. Jan 13, 2015
  5. Jan 09, 2015
    • Roshan Pius's avatar
      port-probe: Increase AT probe command timeout to 7 seconds for altair. · b09ac0d2
      Roshan Pius authored and Aleksander Morgado's avatar Aleksander Morgado committed
      This patch increases the response timeout for the probe AT commands for
      altair modems.
      
      We've been noticing some altair modems taking upto 6 seconds to respond to the
      initial probe command after a reset which results in modem-manager
      timing out and sending a second probe command. The modem sends a response
      after about 6 seconds for the initial probe command which modem-manager
      treats as response to second probe command and this results in the
      modem-manager and modem going out of sync because the modem's second
      probe response is treated as response to the next initialization AT command
      sent by modem-manager and so on.
      
      Change-Id: Iad8b0786327b153fd95c8ee4516f352325a42cf7
      b09ac0d2
    • Aleksander Morgado's avatar
      broadband-modem-qmi: fix memleak when listing SMS · a6adb064
      Aleksander Morgado authored
      If we get multiple message lists, we need to make sure the previous one is
      cleared out before going to the next one.
      a6adb064
  6. Dec 30, 2014
    • Aleksander Morgado's avatar
      mbim: don't assume 'Command Done' is always replied to 'Command' messages · 7d46910b
      Aleksander Morgado authored
      Since libmbim 1.11.1, mbim_device_command_finish() may return messages of type
      'Function Error', so we shouldn't assume 'Command Done' messages are returned.
      
      This commit is equivalent to this one in git master, but instead of bumping the
      libmbim requirement to 1.11.1, we provide a fallback implementation so that the
      same logic works when libmbim is < 1.11.1.
      
          commit 46b707f8
          Author: Aleksander Morgado <aleksander@aleksander.es>
          Date:   Sun Dec 28 17:55:50 2014 +0100
      
              mbim: use the new response checker helper method
      
              mbim_message_response_get_result() is available in libmbim-glib 1.11.1.
      7d46910b
  7. Dec 26, 2014
  8. Dec 03, 2014
    • Aleksander Morgado's avatar
      port-probe: retry icera probing up to 3 times, with some time in between cmds · 4251bc40
      Aleksander Morgado authored
      Icera-based modems need to return a correct response to the AT%IPSYS? command,
      so that they are properly detected as being Icera-based.
      
      Now, some modems, like the Nokia 21M-02, don't seem to return a correct response
      to AT%IPSYS just after being plugged in. So, setup a retry mechanism (3 retries,
      with 2 seconds between retries) to try to cope with this issue.
      
      https://bugs.freedesktop.org/show_bug.cgi?id=85012
      
      Logs from the error situation:
      
      [mm-port-serial-at.c:440] debug_log(): (ttyACM0): --> 'ATE1 E0<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM2): --> 'ATE1 E0<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM1): --> 'ATE1 E0<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM0): <-- 'E0'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM0): <-- '<CR><CR><LF>ERROR<CR><LF>'
      [mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
      [mm-port-probe-at.c:43] mm_port_probe_response_processor_is_at(): Parsing AT got: 'Unknown error'
      [mm-port-probe.c:155] mm_port_probe_set_result_at(): (tty/ttyACM0) port is AT-capable
      [mm-port-serial-at.c:440] debug_log(): (ttyACM2): <-- 'ATE1 E0'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM1): <-- ' E0'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM2): <-- '<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM1): <-- '<CR><CR><LF>ERROR<CR><LF>'
      [mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
      [mm-port-probe-at.c:43] mm_port_probe_response_processor_is_at(): Parsing AT got: 'Unknown error'
      [mm-port-probe.c:155] mm_port_probe_set_result_at(): (tty/ttyACM1) port is AT-capable
      [mm-port-serial-at.c:440] debug_log(): (ttyACM2): <-- '<CR><LF>OK<CR><LF>'
      [mm-port-probe.c:155] mm_port_probe_set_result_at(): (tty/ttyACM2) port is AT-capable
      [mm-port-serial-at.c:440] debug_log(): (ttyACM0): --> 'AT%IPSYS?<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM1): --> 'AT%IPSYS?<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM2): --> 'AT%IPSYS?<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM0): <-- 'AT%IPSYS?'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM0): <-- '<CR>'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM1): <-- 'AT%IPSYS?'
      [mm-port-serial-at.c:440] debug_log(): (ttyACM1): <-- '<CR><CR><LF>ERROR<CR><LF>'
      4251bc40
    • Aleksander Morgado's avatar
      icera: IPv6 '::' is a placeholder for 'no IPv6', so don't error out if found · 1820dc31
      Aleksander Morgado authored
      Also, allow IPDPADDR returns where only DNS IPv6 is given (i.e. no IPv6 address
      to set), and in that case default to DHCP method in the bearer.
      
      https://bugs.freedesktop.org/show_bug.cgi?id=85012
      1820dc31
    • Aleksander Morgado's avatar
      huawei: expect 'modem' and 'pcui' in ^GETPORTMODE responses · 6a1b3e13
      Aleksander Morgado authored
      Newer huawei modems, like the E3372, use the following ^GETPORTMODE response
      format:
        ^GETPORTMODE: TYPE: WCDMA: ,pcui:1,modem:2,ncm:3,mass:4,mass_two:5,
      
      This patch updates the parser that looks for the control TTY (pcui) and data TTY
      (modem).
      
      https://bugs.freedesktop.org/show_bug.cgi?id=86658
      6a1b3e13
  9. Nov 14, 2014
  10. Oct 29, 2014
  11. Oct 28, 2014
  12. Oct 07, 2014
    • Dan Williams's avatar
      port-serial: fix forced closing after b2823041 · 009af02f
      Dan Williams authored
      b2823041 moved up the self->priv->forced_close = TRUE, which
      caused mm_port_serial_close() to just return without actually
      closing the port and cleaning up.
      
      Also, cancel the reopen separately from closing the port since
      the two operations are actually independent of each other.
      009af02f
  13. Sep 05, 2014
  14. Aug 22, 2014
  15. Aug 18, 2014
    • Dan Williams's avatar
      qmi: always use DHCP for IPv4 configuration instead of STATIC · 0c6f1ae6
      Dan Williams authored
      Some newer modems (Huawei E1750, Sierra 73xx) provide what looks like
      legitimate static IPv4 configuration through the WDSGetCurrentSettings
      call, but when configured the interface does not pass traffic.  Running
      DHCP on the same interface provides a slightly different IPv4
      configuration but does allow traffic to pass.
      
      Since QMI was switched to static originally for consistency with IPv6
      and for speed of IP configuration (since DHCP takes a bit of time), but
      not for any known problems with modems, let's switch back to DHCP until
      we have time to figure out what's actually going on.
      0c6f1ae6
    • Aleksander Morgado's avatar
      bearer-qmi: allow forcing DHCP instead of static IP config · b03e1cfd
      Aleksander Morgado authored and Dan Williams's avatar Dan Williams committed
      b03e1cfd
  16. Aug 12, 2014
  17. Aug 11, 2014
  18. Aug 05, 2014
  19. Aug 04, 2014
    • Aleksander Morgado's avatar
      build: require libmbim 1.10.0 · 3dd6f931
      Aleksander Morgado authored
      We were depending on some new MbimNwError values defined at some point in the
      1.9 development series. Depend on the new stable 1.10 version now that it's been
      released.
      3dd6f931
  20. Jul 29, 2014
  21. Jul 27, 2014
    • Aleksander Morgado's avatar
      plugin: improve probing decision logic for QMI and MBIM · f203b1bf
      Aleksander Morgado authored
      So, we may have modems with multiple /dev/cdc-wdm ports, like Ericsson modems,
      where only 1 of them is MBIM. With the previous logic, we would probe all
      /dev/cdc-wdm ports for MBIM as soon as one of the ports was handled by the
      cdc_mbim driver. That is totally not optimal, as we are already know that they
      are not MBIM (not handled by cdc_mbim).
      
      Instead, fix the logic to just probe for MBIM or QMI if the actual driver
      managing the port is MBIM or QMI.
      f203b1bf
  22. Jul 17, 2014
    • Ben Chan's avatar
      broadband-modem-mbim: increase timeout for powering modem up and down · 0284daf8
      Ben Chan authored and Dan Williams's avatar Dan Williams committed
      It's been observed that some modems occasionally take a long time to
      power down (which may be due to some shutdown sequence that involves
      communicating with network). This patch increases the timeout for
      powering modem up and down from 10s to 20s.
      0284daf8
    • Ben Chan's avatar
      bearer-mbim: increase disconnect timeout · 8a56cd4c
      Ben Chan authored and Dan Williams's avatar Dan Williams committed
      It's been observed that modems may take a long time to disconnect from
      the network under certain network conditions. This patch increases the
      timeout for the MBIM_CID_CONNECT set command in the disconnect sequence
      from 10s to 30s.
      8a56cd4c
Loading