Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dbus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 253
    • Issues 253
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dbus
  • dbus
  • Merge requests
  • !88

Adapt to API change in AX_CODE_COVERAGE version 28

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon McVittie requested to merge smcv/dbus:code-coverage into master Jan 21, 2019
  • Overview 8
  • Commits 3
  • Pipelines 1
  • Changes 13

AX_CODE_COVERAGE recently changed the way it embedded its Makefile rules in the output file: instead of using @CODE_COVERAGE_RULES@, users are now meant to include aminclude_static.am.

The new AX_CODE_COVERAGE is only in the latest autoconf-archive release, version 2019.01.06, which is inconveniently new, so bundle everything we need for the moment.

This requires us to stop using the deprecated CODE_COVERAGE_LDFLAGS (which we still used to support older versions of autoconf-archive) and replace them with CODE_COVERAGE_LIBS.


Consistently add CODE_COVERAGE_LIBS everywhere

We need to link the code coverage objects, directly or indirectly, into every executable and every shared library. The rule I've followed to make it clear that we do this, without too much repetition, is: each executable, shared library or convenience library has CODE_COVERAGE_LIBS in its LDADD or LIBADD, unless it is linked to a convenience library in the same directory that has CODE_COVERAGE_LIBS in its LIBADD.


Consistently add CODE_COVERAGE_CPPFLAGS everywhere

We forgot this in a couple of places.


First commit proposed for dbus-1.12. Second and third commits probably not.

Resolves #249 (closed)

Edited Jan 21, 2019 by Simon McVittie
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: code-coverage