Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • D dbus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 264
    • Issues 264
    • List
    • Boards
    • Service Desk
    • Milestones
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • dbusdbus
  • dbus
  • Merge requests
  • !28

Fix whitespace and error behaviour for _dbus_command_from_pid()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon McVittie requested to merge smcv/dbus:222-comm-whitespace into master Oct 25, 2018
  • Overview 4
  • Commits 9
  • Pipelines 5
  • Changes 7

In addition to fixing the additional space reported in #222 (closed), this branch adds test coverage, and fixes the error behaviour of the Windows implementation.

See individual commits:

  • sysdeps: Remove trailing NUL from command lines from /proc
  • tests: Build test-sleep-forever even if embedded tests are disabled
  • tests: Add a unit test for _dbus_command_for_pid()
  • sysdeps: Return an error for _dbus_command_for_pid on Windows
  • tests: Assert that _dbus_command_for_pid() has correct error behaviour

Closes #222 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 222-comm-whitespace